-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introduce tokens for stack spacing and Row component #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentSmedinga
commented
Mar 7, 2024
github-actions
bot
temporarily deployed
to
demo-DES-617-horizontal-stack-space
March 7, 2024 13:38
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-617-horizontal-stack-space
March 7, 2024 15:21
Destroyed
alimpens
reviewed
Mar 8, 2024
This reverts commit fa592d8.
github-actions
bot
temporarily deployed
to
demo-DES-617-horizontal-stack-space
March 8, 2024 10:22
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-617-horizontal-stack-space
March 8, 2024 10:26
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-617-horizontal-stack-space
March 8, 2024 10:30
Destroyed
alimpens
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a
Row
component, for now exactly the same asColumn
, but a separate component as we foresee different alignment properties between the two.Setting this up made me lean towards the idea that vertical space in
Grid
should be responsive, but inColumn
it should be fixed-width just like inRow
. If so, we can keep the name ‘stack space’ for the tokens and set them as values for the column gap tokens as well.