Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce tokens for stack spacing and Row component #1113

Merged
merged 10 commits into from
Mar 8, 2024

Conversation

VincentSmedinga
Copy link
Contributor

@VincentSmedinga VincentSmedinga commented Mar 7, 2024

This introduces a Row component, for now exactly the same as Column, but a separate component as we foresee different alignment properties between the two.

Setting this up made me lean towards the idea that vertical space in Grid should be responsive, but in Column it should be fixed-width just like in Row. If so, we can keep the name ‘stack space’ for the tokens and set them as values for the column gap tokens as well.

@VincentSmedinga VincentSmedinga marked this pull request as ready for review March 7, 2024 13:33
@VincentSmedinga VincentSmedinga requested review from alimpens and dlnr March 7, 2024 13:33
@github-actions github-actions bot temporarily deployed to demo-DES-617-horizontal-stack-space March 7, 2024 13:38 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-617-horizontal-stack-space March 7, 2024 15:21 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-617-horizontal-stack-space March 8, 2024 10:22 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-617-horizontal-stack-space March 8, 2024 10:26 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-617-horizontal-stack-space March 8, 2024 10:30 Destroyed
@alimpens alimpens merged commit f5dba78 into develop Mar 8, 2024
4 checks passed
@alimpens alimpens deleted the feature/DES-617-horizontal-stack-space branch March 8, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants