Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Rename ‘header logo’ to ‘header logo link’ and add missing token for outline offset #1108

Merged
merged 7 commits into from
Mar 8, 2024
Merged

feat!: Rename ‘header logo’ to ‘header logo link’ and add missing token for outline offset #1108

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e9fc820
Add missing tokens for offset of link on header logo
VincentSmedinga Feb 29, 2024
645bf0d
Rename ‘header logo’ to ‘header logo link’
VincentSmedinga Mar 7, 2024
82d3f34
Merge branch 'develop' into feature/header-logo-link-offset-token
VincentSmedinga Mar 7, 2024
f5695c1
Merge branch 'develop' into feature/header-logo-link-offset-token
VincentSmedinga Mar 7, 2024
9a37fa1
Fix token hierarchy
VincentSmedinga Mar 7, 2024
c1dbc41
Merge branch 'develop' into feature/header-logo-link-offset-token
VincentSmedinga Mar 7, 2024
3994d17
Merge branch 'develop' into feature/header-logo-link-offset-token
alimpens Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/css/src/components/header/header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
}
}

.amsterdam-header__logo {
.amsterdam-header__logo-link {
flex: none;
outline-offset: var(--amsterdam-link-outline-offset);
outline-offset: var(--amsterdam-header-logo-link-outline-offset);
}

.amsterdam-header__links {
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/Header/Header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export const Header = forwardRef(
return (
<>
<header {...restProps} ref={ref} className={clsx('amsterdam-header', className)}>
<a href={logoLink} className="amsterdam-header__logo">
<a href={logoLink} className="amsterdam-header__logo-link">
<VisuallyHidden>{logoLinkTitle}</VisuallyHidden>
<Logo brand={logoBrand} />
</a>
Expand Down
5 changes: 4 additions & 1 deletion proprietary/tokens/src/components/amsterdam/header.tokens.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@
"value": "{amsterdam.space.md}",
"comment": "Must have the same value as `amsterdam.grid.column-gap`."
},
"padding-block": { "value": "{amsterdam.space.inside.md}" }
"logo-link": {
"outline-offset": { "value": "{amsterdam.focus.outline-offset}" },
"padding-block": { "value": "{amsterdam.space.inside.md}" }
alimpens marked this conversation as resolved.
Show resolved Hide resolved
}
}
}
}
Loading