Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Radio, update Checkbox and Switch #1100

Merged
merged 17 commits into from
Mar 6, 2024

Conversation

alimpens
Copy link
Contributor

@alimpens alimpens commented Mar 1, 2024

This adds a Radio component. During development I ran into issues which also apply to Checkbox and Switch, so I've updated those as well. The most important change in that regard is a fix for invisible focus rings on older browsers that do not support focus-visible (e.g. Safari < 15.4).

@alimpens alimpens changed the title feat: Add Radio feat: Add Radio, update Checkbox and Switch Mar 1, 2024
@github-actions github-actions bot temporarily deployed to demo-DES-36-radio-button March 1, 2024 13:06 Destroyed
@alimpens alimpens requested review from VincentSmedinga and dlnr March 1, 2024 13:11
@github-actions github-actions bot temporarily deployed to demo-DES-36-radio-button March 4, 2024 11:31 Destroyed
packages/css/src/components/checkbox/checkbox.scss Outdated Show resolved Hide resolved
packages/css/src/components/radio/radio.scss Outdated Show resolved Hide resolved
packages/css/src/components/radio/radio.scss Show resolved Hide resolved
packages/css/src/components/radio/radio.scss Outdated Show resolved Hide resolved
packages/css/src/components/radio/radio.scss Outdated Show resolved Hide resolved
packages/css/src/components/radio/radio.scss Outdated Show resolved Hide resolved
packages/react/src/Radio/Radio.test.tsx Outdated Show resolved Hide resolved
packages/css/src/components/radio/radio.scss Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to demo-DES-36-radio-button March 5, 2024 15:56 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-36-radio-button March 5, 2024 16:17 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-36-radio-button March 6, 2024 13:05 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-36-radio-button March 6, 2024 13:10 Destroyed
VincentSmedinga
VincentSmedinga previously approved these changes Mar 6, 2024
@github-actions github-actions bot temporarily deployed to demo-DES-36-radio-button March 6, 2024 13:14 Destroyed
@VincentSmedinga VincentSmedinga merged commit 79224e3 into develop Mar 6, 2024
4 checks passed
@VincentSmedinga VincentSmedinga deleted the feature/DES-36-radio-button branch March 6, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants