You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
Looks good, weird how the legend has always been a thing that wants to live in the middle of the fieldset line. And also that the legend is not actually required, just for a11y purposed it is recommended.
Looks good, weird how the legend has always been a thing that wants to live in the middle of the fieldset line. And also that the legend is not actually required, just for a11y purposed it is recommended.
Yeah, the default styling is a bit odd. I think it makes sense to require the legend in ADS, a fieldset without a legend is a bit pointless imo.
Looks good, weird how the legend has always been a thing that wants to live in the middle of the fieldset line. And also that the legend is not actually required, just for a11y purposed it is recommended.
Yeah, the default styling is a bit odd. I think it makes sense to require the legend in ADS, a fieldset without a legend is a bit pointless imo.
You're probably right, but.. you can pass a form attribute to the fieldset to connect it to a form outside of the form tag. Perhaps developer might need this in some odd sidecases. And they might not need a heading then.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.