Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow lists to appear in white on a dark background #1074

Merged
merged 19 commits into from
Feb 19, 2024
Merged

feat: Allow lists to appear in white on a dark background #1074

merged 19 commits into from
Feb 19, 2024

Conversation

dlnr
Copy link
Contributor

@dlnr dlnr commented Feb 12, 2024 •
edited
Loading

Just like paragraphs the lists are now able to handle inverseColor for dark backgrounds.

@github-actions github-actions bot temporarily deployed to demo-DES-610-inverse-color-lists February 12, 2024 13:48 Destroyed
@dlnr dlnr marked this pull request as ready for review February 12, 2024 13:49
VincentSmedinga
VincentSmedinga reviewed Feb 13, 2024
View reviewed changes
Copy link
Contributor

@VincentSmedinga VincentSmedinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this one up! I think the selector should be more specific, we can sort lists of restructured props and prop objects, and we could use explicit examples.

packages/css/src/components/ordered-list/ordered-list.scss Outdated Show resolved Hide resolved
packages/css/src/components/ordered-list/ordered-list.scss Outdated Show resolved Hide resolved
packages/css/src/components/unordered-list/unordered-list.scss Outdated Show resolved Hide resolved
packages/react/src/OrderedList/OrderedList.tsx Outdated Show resolved Hide resolved
packages/react/src/OrderedList/OrderedList.tsx Outdated Show resolved Hide resolved
packages/react/src/UnorderedList/UnorderedList.tsx Outdated Show resolved Hide resolved
packages/react/src/UnorderedList/UnorderedList.tsx Outdated Show resolved Hide resolved
packages/react/src/UnorderedList/UnorderedList.tsx Outdated Show resolved Hide resolved
storybook/storybook-react/src/OrderedList/OrderedList.stories.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to demo-DES-610-inverse-color-lists February 13, 2024 09:09 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-610-inverse-color-lists February 13, 2024 09:13 Destroyed
dlnr and others added 6 commits February 13, 2024 10:13
@github-actions github-actions bot temporarily deployed to demo-DES-610-inverse-color-lists February 13, 2024 09:15 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-610-inverse-color-lists February 13, 2024 09:26 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-610-inverse-color-lists February 13, 2024 09:32 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-610-inverse-color-lists February 13, 2024 09:59 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-610-inverse-color-lists February 13, 2024 10:06 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-610-inverse-color-lists February 13, 2024 10:34 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-610-inverse-color-lists February 13, 2024 10:48 Destroyed
@VincentSmedinga VincentSmedinga changed the title fix: Inverse color boolean for lists feat: Allow lists to appear in white on a dark background Feb 13, 2024
@github-actions github-actions bot temporarily deployed to demo-DES-610-inverse-color-lists February 19, 2024 22:19 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-610-inverse-color-lists February 19, 2024 22:32 Destroyed
@VincentSmedinga VincentSmedinga merged commit 14132ed into develop Feb 19, 2024
4 checks passed
@VincentSmedinga VincentSmedinga deleted the feature/DES-610-inverse-color-lists branch February 19, 2024 22:35
@github-actions github-actions bot mentioned this pull request Mar 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimpens alimpens alimpens left review comments

@VincentSmedinga VincentSmedinga VincentSmedinga approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlnr @VincentSmedinga @alimpens