feat: Add Tabs component #1068

dlnr · 2024-02-07T08:01:34Z

Documentation used:

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/tab_role
- Will we be using vertical tabs?
https://react.dev/reference/react/useTransition
https://react.dev/reference/react/useContext

…into feature/DES-607-Tabs

Co-authored-by: Aram <[email protected]>

…esign-system into feature/DES-607-Tabs

VincentSmedinga

Quite a job, well done.

dlnr added 3 commits February 6, 2024 09:08

Scaffold and basic styling

240f73b

Tab story

887f636

Working on interaction

564aa29

github-actions bot temporarily deployed to demo-DES-607-Tabs February 7, 2024 10:24 Destroyed

Switching tabs with context

3a9eed2

github-actions bot temporarily deployed to demo-DES-607-Tabs February 8, 2024 11:56 Destroyed

Context in external file, cleanup

ab8462e

github-actions bot temporarily deployed to demo-DES-607-Tabs February 8, 2024 13:28 Destroyed

Keyboard navigation

6fc764c

github-actions bot temporarily deployed to demo-DES-607-Tabs February 8, 2024 14:11 Destroyed

Home and End button

e7cbbbd

github-actions bot temporarily deployed to demo-DES-607-Tabs February 8, 2024 14:19 Destroyed

Mobile overflow

13b4558

github-actions bot temporarily deployed to demo-DES-607-Tabs February 9, 2024 14:22 Destroyed

Hover effect and some docs

ef97f36

github-actions bot temporarily deployed to demo-DES-607-Tabs February 9, 2024 22:20 Destroyed

dlnr added 2 commits February 9, 2024 23:20

Typo

dafeb4d

Single tab

f08368e

github-actions bot temporarily deployed to demo-DES-607-Tabs February 9, 2024 22:22 Destroyed

Merge branch 'develop' of https://github.com/Amsterdam/design-system …

503e5b9

…into feature/DES-607-Tabs

github-actions bot temporarily deployed to demo-DES-607-Tabs February 12, 2024 09:16 Destroyed

typography and underline fixes

a72cfe5

github-actions bot temporarily deployed to demo-DES-607-Tabs February 12, 2024 09:52 Destroyed

Overflow not for desktop

67ff1ca

github-actions bot temporarily deployed to demo-DES-607-Tabs February 12, 2024 12:02 Destroyed

Testing rendering

8007243

github-actions bot temporarily deployed to demo-DES-607-Tabs February 12, 2024 13:06 Destroyed

Merge branch 'develop' of https://github.com/Amsterdam/design-system …

f5a94c9

…into feature/DES-607-Tabs

github-actions bot temporarily deployed to demo-DES-607-Tabs February 14, 2024 08:18 Destroyed

Refactor focus navigation in Tabs component

149b955

github-actions bot temporarily deployed to demo-DES-607-Tabs February 27, 2024 15:12 Destroyed

Remove link-appearance tokens

8283ee5

github-actions bot temporarily deployed to demo-DES-607-Tabs February 27, 2024 15:24 Destroyed

License header

19d8bdc

github-actions bot temporarily deployed to demo-DES-607-Tabs February 27, 2024 15:26 Destroyed

Licensing

f2e74a0

github-actions bot temporarily deployed to demo-DES-607-Tabs February 27, 2024 15:38 Destroyed

Refactor SlowTab

3bdac54

github-actions bot temporarily deployed to demo-DES-607-Tabs February 27, 2024 16:06 Destroyed

Update proprietary/tokens/src/components/amsterdam/tabs.tokens.json

e94f714

Co-authored-by: Aram <[email protected]>

github-actions bot temporarily deployed to demo-DES-607-Tabs February 27, 2024 16:41 Destroyed

ChildComponent tests

40efe3a

github-actions bot temporarily deployed to demo-DES-607-Tabs February 28, 2024 09:47 Destroyed

dlnr and others added 2 commits February 28, 2024 10:50

Refactor Tabs component structure

9e29083

Add TabsButton tests

9342fd4

github-actions bot temporarily deployed to demo-DES-607-Tabs February 28, 2024 10:16 Destroyed

alimpens added 4 commits February 28, 2024 11:17

Fix string literal

49e337e

Add tabspanel test

9117745

Add test for changing panels

e2872f2

Merge branch 'feature/DES-607-Tabs' of https://github.com/Amsterdam/d…

281613e

…esign-system into feature/DES-607-Tabs

github-actions bot temporarily deployed to demo-DES-607-Tabs February 28, 2024 10:53 Destroyed

alimpens added 2 commits February 28, 2024 12:49

Use children instead of label

437b253

Omit default param

3df2331

github-actions bot temporarily deployed to demo-DES-607-Tabs February 28, 2024 11:51 Destroyed

Merge branch 'develop' into feature/DES-607-Tabs

66936be

github-actions bot temporarily deployed to demo-DES-607-Tabs February 29, 2024 10:54 Destroyed

VincentSmedinga approved these changes Feb 29, 2024

View reviewed changes

VincentSmedinga merged commit 4eec887 into develop Feb 29, 2024
4 checks passed

VincentSmedinga deleted the feature/DES-607-Tabs branch February 29, 2024 11:05

github-actions bot mentioned this pull request Mar 8, 2024

chore(release): Publish new release(s) #1120

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add Tabs component #1068

feat: Add Tabs component #1068

dlnr commented Feb 7, 2024 •

edited

Loading

VincentSmedinga left a comment

feat: Add Tabs component #1068

feat: Add Tabs component #1068

Conversation

dlnr commented Feb 7, 2024 • edited Loading

VincentSmedinga left a comment

Choose a reason for hiding this comment

dlnr commented Feb 7, 2024 •

edited

Loading