Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Remove deprecated ‘in list’ variant of Link #1064

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

VincentSmedinga
Copy link
Contributor

@VincentSmedinga VincentSmedinga commented Jan 31, 2024

We deprecated this value for the variant prop of List in yesterday’s release. This PR removes it for the next release.

It also updates all our examples – something we should actually have done with the deprecation. This includes making the links in the Footer small, and the primary ones in the Mega Menu large. Sorry for not separating commits.

@VincentSmedinga VincentSmedinga changed the title fix!: Remove deprecated ‘in list’ variant of Link feat!: Remove deprecated ‘in list’ variant of Link Feb 1, 2024
packages/react/src/Link/Link.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to demo-remove-in-list-link February 9, 2024 12:59 Destroyed
@VincentSmedinga VincentSmedinga merged commit b30784b into develop Feb 9, 2024
4 checks passed
@VincentSmedinga VincentSmedinga deleted the feature/remove-in-list-link branch February 9, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants