Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Refactor subcomponents #1050

Merged
merged 15 commits into from
Jan 24, 2024
Merged

fix: Refactor subcomponents #1050

merged 15 commits into from
Jan 24, 2024

Conversation

alimpens
Copy link
Contributor

No description provided.

@github-actions github-actions bot temporarily deployed to demo-DES-569-refactor-subcomponents January 19, 2024 14:35 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-569-refactor-subcomponents January 19, 2024 14:38 Destroyed
dlnr
dlnr reviewed Jan 22, 2024
View reviewed changes
Copy link
Contributor

@dlnr dlnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autocompletion is an issue for me, the benefit of the child components was that they were exclusively to be used inside the parent and now they are an import autocomplete everywhere.

packages/react/src/PageMenu/PageMenu.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to demo-DES-569-refactor-subcomponents January 22, 2024 17:01 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-569-refactor-subcomponents January 22, 2024 17:04 Destroyed
VincentSmedinga
VincentSmedinga reviewed Jan 23, 2024
View reviewed changes
Copy link
Contributor

@VincentSmedinga VincentSmedinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh so pretty.

packages/react/src/Breadcrumb/BreadcrumbItem.tsx Show resolved Hide resolved
packages/react/src/Card/CardHeadingGroup.test.tsx Show resolved Hide resolved
packages/react/src/Footer/Footer.test.tsx Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to demo-DES-569-refactor-subcomponents January 23, 2024 09:38 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-569-refactor-subcomponents January 23, 2024 11:06 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-569-refactor-subcomponents January 24, 2024 09:40 Destroyed
@VincentSmedinga VincentSmedinga merged commit 9e48aec into develop Jan 24, 2024
4 checks passed
@VincentSmedinga VincentSmedinga deleted the task/DES-569-refactor-subcomponents branch January 24, 2024 09:58
@VincentSmedinga VincentSmedinga mentioned this pull request Feb 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlnr dlnr dlnr approved these changes

@VincentSmedinga VincentSmedinga VincentSmedinga approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alimpens @VincentSmedinga @dlnr