feat: Add Tip Component #1048
Closed
feat: Add Tip Component #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/DES-331-Badge
…design-system into feature/DES-544-Tip
…into feature/DES-331-Badge
…design-system into feature/DES-544-Tip
…into feature/DES-544-Tip
|
We decided against including this component now. It’s unclear if and how it will be used, and the implementation is not much more than a flex row with a gap and some padding. Until we offer something specific, people can wrap a Badge and a Paragraph in a small custom container. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the Badge to the tip raises a couple of questions. Do we need to inherit the font-size of the other child? And do we need to add a required "badge" prop to enforce the badge (and badge color)?