feat!: Allow zero row gap for Grid #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentSmedinga
requested changes
Jan 11, 2024
| @@ -9,8 +9,8 @@ | |||
| --amsterdam-grid-gap: var(--amsterdam-grid-spacious-gap); | |||
| --amsterdam-grid-padding-inline: var(--amsterdam-grid-spacious-padding-inline); | |||
|
|
|||
| column-gap: var(--amsterdam-grid-gap); | |||
There was a problem hiding this comment.
This removes the row gap by default, which is not what we want. We rely on the vertical gap being the same as the horizontal one by default, e.g. when moving cells around respponsively and in grids of cards or top task buttons.
packages/react/src/Grid/Grid.tsx
Outdated
| @@ -48,7 +48,7 @@ export type GridProps = { | |||
| */ | |||
| compact?: boolean | |||
| /** The amount of vertical whitespace between rows of the grid. */ | |||
| gapVertical?: 'small' | 'large' | |||
| gapVertical?: 'small' | 'medium' | 'large' | |||
There was a problem hiding this comment.
So I think medium should be the default, and this prop should accept a none value.
github-actions
bot
temporarily deployed
to
demo-DES-540-allow-zero-row-gap-grid
VincentSmedinga
approved these changes
Jan 12, 2024
github-actions
bot
temporarily deployed
to
demo-DES-540-allow-zero-row-gap-grid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.