Skip to content

Commit

Permalink
Let Footer set its own background colour
Browse files Browse the repository at this point in the history
This allows us to remove the blue option from Spotlight, which should not be used.
  • Loading branch information
VincentSmedinga committed Dec 19, 2024
1 parent fa42211 commit 8e6d251
Show file tree
Hide file tree
Showing 5 changed files with 24 additions and 7 deletions.
8 changes: 4 additions & 4 deletions packages/css/src/components/footer/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,17 @@ Provides service information at the bottom of every page.

## Guidelines

- The Footer consists of a dark blue [Spotlight](/docs/components-containers-spotlight--docs) and a [Page Menu](/docs/components-navigation-page-menu--docs).
- The Footer consists of two sections: a full-width blue area and a [Page Menu](/docs/components-navigation-page-menu--docs) below it.
It must be used on all websites for the City of Amsterdam.
- For applications, only the Page Menu can be sufficient.
- The Footer is the same on every page of the application.
- For applications, only the Page Menu can be sufficient.

The Spotlight offers space for various practical links:
The top section offers space for various practical links:

- The first column focuses on contact information.
The information is as specific as possible and tailored to the respective website or page (e.g., including a chat option if available).
- The second column contains links to relevant (online) sites or sources.
- The third column refers to newsletters, social media, etc.

The menu at the very bottom is intended for links to privacy policies, cookie statements, information about the website itself, etc.
The menu in the bottom section is for links to privacy policies, cookie statements, information about the website itself, etc.
Contact details should not go here.
8 changes: 8 additions & 0 deletions packages/css/src/components/footer/footer.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
/**
* @license EUPL-1.2+
* Copyright Gemeente Amsterdam
*/

.ams-footer__top {
background-color: var(--ams-footer-top-background-color);
}
1 change: 1 addition & 0 deletions packages/css/src/components/index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
*/

/* Append here */
@use "footer/footer";
@use "file-list/file-list";
@use "action-group/action-group";
@use "breakout/breakout";
Expand Down
5 changes: 2 additions & 3 deletions packages/react/src/Footer/FooterTop.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,14 @@
import clsx from 'clsx'
import { forwardRef } from 'react'
import type { ForwardedRef, HTMLAttributes, PropsWithChildren } from 'react'
import { Spotlight } from '../Spotlight/Spotlight'

export type FooterTopProps = PropsWithChildren<HTMLAttributes<HTMLDivElement>>

export const FooterTop = forwardRef(
({ children, className, ...restProps }: FooterTopProps, ref: ForwardedRef<HTMLDivElement>) => (
<Spotlight {...restProps} color="blue" ref={ref} className={clsx('ams-footer__top', className)}>
<div {...restProps} ref={ref} className={clsx('ams-footer__top', className)}>
{children}
</Spotlight>
</div>
),
)

Expand Down
9 changes: 9 additions & 0 deletions proprietary/tokens/src/components/ams/footer.tokens.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"ams": {
"footer": {
"top": {
"background-color": { "value": "{ams.brand.color.blue.60}" }
}
}
}
}

0 comments on commit 8e6d251

Please sign in to comment.