Skip to content

Commit

Permalink
Remove tokens that just set initial values
Browse files Browse the repository at this point in the history
They would be useful for communities that reuse our components and need background and border colours, but we should first consider whether we want to adopt this approach.
  • Loading branch information
VincentSmedinga committed Dec 4, 2024
1 parent 226128c commit 4ff5a73
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 10 deletions.
5 changes: 0 additions & 5 deletions packages/css/src/components/tabs/tabs.scss
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@
}

.ams-tabs__list {
background-color: var(--ams-tabs-list-background-color);
border-block-end: var(--ams-tabs-list-border-block-end);
box-shadow: var(--ams-tabs-list-box-shadow);
display: flex;
overflow-x: auto;
Expand All @@ -41,7 +39,6 @@
@include reset-button;

&:disabled {
background-color: var(--ams-tabs-button-disabled-background-color);
color: var(--ams-tabs-button-disabled-color);
cursor: var(--ams-tabs-button-disabled-cursor);

Expand All @@ -51,13 +48,11 @@
}

&:hover:not([aria-selected="true"], [disabled]) {
background-color: var(--ams-tabs-button-hover-background-color);
box-shadow: var(--ams-tabs-button-hover-box-shadow);
color: var(--ams-tabs-button-hover-color);
}

&[aria-selected="true"] {
background-color: var(--ams-tabs-button-selected-background-color);
box-shadow: var(--ams-tabs-button-selected-box-shadow);
color: var(--ams-tabs-button-selected-color);
font-weight: var(--ams-tabs-button-selected-font-weight);
Expand Down
5 changes: 0 additions & 5 deletions proprietary/tokens/src/components/ams/tabs.tokens.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
"tabs": {
"gap": { "value": "{ams.space.md}" },
"list": {
"background-color": { "value": "initial" },
"border-block-end": { "value": "initial" },
"box-shadow": { "value": "inset 0 calc({ams.border.width.md} * -1) {ams.brand.color.neutral.20}" }
},
"button": {
Expand All @@ -19,17 +17,14 @@
"padding-inline": { "value": "{ams.space.md}" },
"hover": {
"color": { "value": "{ams.brand.color.blue.80}" },
"background-color": { "value": "initial" },
"box-shadow": { "value": "inset 0 calc({ams.border.width.md} * -1) {ams.brand.color.blue.80}" }
},
"selected": {
"background-color": { "value": "initial" },
"box-shadow": { "value": "inset 0 calc({ams.border.width.xl} * -1) {ams.brand.color.blue.60}" },
"color": { "value": "{ams.brand.color.blue.60}" },
"font-weight": { "value": "{ams.text.font-weight.bold}" }
},
"disabled": {
"background-color": { "value": "initial" },
"color": { "value": "{ams.brand.color.neutral.60}" },
"cursor": { "value": "{ams.action.disabled.cursor}" }
}
Expand Down

0 comments on commit 4ff5a73

Please sign in to comment.