Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove clisymbols and crayon dependencies + remove tidyselect deprecation warnings. #23

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

olivroy
Copy link

@olivroy olivroy commented Dec 11, 2024

Description

I wanted to open this PR to replace clisymbols and crayon dependencies by cli.

However, when trying to run tests, I ran into a problem. I therefore included a simple fix in 671a4b9. Basically, it protects against the case where self$last_update is NULL (length 0)

Finally, when running tests, I noted a lot of tidyselect deprecation warnings. Basically, dplyr::select(.data$col) is deprecated in favor of dplyr::select("col"). Same goes for tidyr::unnest() and dplyr::pull().

Also, using dplyr::across() without fn is deprecated in favour of dplyr::pick(), so I also made this change.

Cheers!

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if applicable)
  • All lint and unit tests passing
  • Extended the README / documentation, if necessary
  • Updated NEWS.md

Additional Comments

N/A

@bgrnwd
Copy link
Member

bgrnwd commented Dec 14, 2024

@olivroy Thanks for the PR! We'll give it a review in the next week or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants