Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-calculate visibility when the conditions change #370

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

pmelab
Copy link
Contributor

@pmelab pmelab commented Nov 12, 2024

Description of changes

Add dependencies to useEffect in ConditionalContent to make sure it re-renders when the condition properties change.

Motivation and context

The Preview should reflect condition changes immediately, for demo purposes.

@pmelab pmelab requested a review from Leksat November 12, 2024 14:19
@pmelab pmelab merged commit 47d63b0 into release Nov 26, 2024
6 checks passed
@pmelab pmelab deleted the fix-conditional-block-previews branch November 26, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants