SLB-445: Integrate Waku with Decap #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmelab
force-pushed
the
SLB-445-waku-decap
branch
from
aa541a4 to
8619a53
Compare
pmelab
force-pushed
the
SLB-445-waku-decap
branch
from
8619a53 to
6f54ee1
Compare
pmelab
force-pushed
the
SLB-445-waku-decap
branch
from
0fae94f to
aa8245c
Compare
dan2k3k4
reviewed
Aug 7, 2024
Leksat
reviewed
Aug 13, 2024
|
@Leksat The green test on the admin ui is actually a false negative. The path can be accessed now, but the UI itself is broken because its not compatible with React 19. Either we manage to have two React versions in the repository without breaking Waku, or Decap compatibility is fixed at some point. Either way, I would defer this to another issue and close this PR to not have it generate conflicts for too long. |
A fetch error might include request and response objects that could contain circular references, potentially causing JSON.stringify to fail.
Leksat
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Motivation and context
Use Decap contents in Waku. Also create an architecture that allows Waku to fetch data from multiple sources through the same GraphQL Schema.
How has this been tested?