Waku integration #287
Draft
Waku integration #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmelab
force-pushed
the
lagoon-waku
branch
3 times, most recently
from
1ef4712 to
5c76a10
Compare
And fix all breaking changes.
To be able to view home- and 404 pages.
dspachos
reviewed
Jun 28, 2024
apps/website/package.json
Outdated
| "serve": "netlify dev --cwd=. --dir=public --port=8000", | ||
| "serve:proxy": "mitmproxy -p 8000 --mode reverse:http://localhost:8002/", | ||
| "serve:proxied": "netlify dev --cwd=. --dir=dist/public --port=8002", | ||
| "serve": "netlify dev --cwd=. --dir=dist/public --port=8000", | ||
| "dev": "pnpm clean && publisher", |
There was a problem hiding this comment.
The clean command is missing here I guess - Phillip responded that it has not cache right now, so there is not point to clear, so perhaps remove it?
Leksat
reviewed
Jul 1, 2024
| <ErrorBoundary | ||
| onError={(error) => { | ||
| if ((error as any).statusCode === 404) { | ||
| window.location.reload(); |
There was a problem hiding this comment.
Aha, so this is the reason of https://waku.amazeelabs.dev/en/content-hub craziness 😅
There was a problem hiding this comment.
Yes, this has to become more solid.
| if (result.state === 'success') { | ||
| const rawTranslations = result.data.stringTranslations || []; | ||
| const translations = { | ||
| ...translationsMap( |
There was a problem hiding this comment.
Just FYI. There is a big performance difference between [...arr1, ...arr2] and arr1.concat(arr2). Can be essential on big arrays.
| if (isLocale(prefix)) { | ||
| setCurrentLocale(prefix); | ||
| } | ||
| }, [setCurrentLocale]); |
There was a problem hiding this comment.
Just a guess: should window.location.pathname be passed as a dependency as well?
SLB-385: focalpoint in waku
SLB-469: redirects for RSC files
Upgrade to current rease 2024-12-06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Swap out Gatsby for Waku.
Motivation and context
Gatsby is not progressing and barely maintained. There is no hope that our current issues will get resolved any time soon.
Remaining issues
How has this been tested?