feat(SLB-306): Info Grid #226
Conversation
| // Your new icon is now available for selection, it will be displayed everywhere all icons are used. | ||
| // Or you can use the limitedIconListOption function to limit the available icons in a specific context. | ||
| // | ||
| // NOTE: search this file for "*" to find the places where you need to add your new icon. |
There was a problem hiding this comment.
I would simplify it. I think we can use TS types here in the way that no comments will be needed.
There was a problem hiding this comment.
Actually I'm not sure if this file is needed at all. Because everything it contains is used only once, and maybe can be inlined (?)
There was a problem hiding this comment.
Well my idea here is that it should be used more that once, anywhere we give options to select icons in blocks.
I already can see in the CTA buttons we give the option for arrow icons before or after text but nothing gets displayed to the user while making these changes.
Also icon selection is quite a common request for PMs, so I was trying to make a reusable and dynamic libarary just for use on the Gutenberg side.
| icons: Icons[], | ||
| addDefault: boolean = true, | ||
| defaultLabel: string = 'Select an icon', | ||
| defaultValue: string = '', |
There was a problem hiding this comment.
At the moment the function is used with only the first arg passed. Everything else is always default.
It looks like the function is designed with future use-cases in mind. But that future might never come 😛
packages/drupal/test_content/content/node/a397ca48-8fad-411e-8901-0eba2feb989c.yml
Outdated
Show resolved
Hide resolved
Description of changes
Adds info grid block.
How has this been tested?