Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preview urls on dev and stage environments #224

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Conversation

colorfield
Copy link
Member

@colorfield colorfield commented May 8, 2024

Description of changes

  • add Lagoon PROJECT_NAME env var to preview
  • adjust init
  • refactor CMS env vars to use the same pattern and set it for dev environment

Motivation and context

Noticed CORS issues on dev and stage when using the preview.
Domain prefix was dev-.

See https://amazeelabs.slack.com/archives/C02ELKC86L9/p1715184263014659

How has this been tested?

  • Manually
  • Unit tests
  • Integration tests

@colorfield colorfield requested a review from pmelab May 8, 2024 17:55
@colorfield colorfield changed the title chore: add PROJECT_NAME env var to preview fix: preview urls on dev and stage environments Jun 26, 2024
@colorfield
Copy link
Member Author

Tested and reviewed as part of #285, merging so we don't have a regression if we reset stage

@colorfield colorfield merged commit 9e0ddf2 into release Jun 27, 2024
4 of 5 checks passed
@colorfield colorfield deleted the fix-preview branch June 27, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant