Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLB-304: Hero form #181

Merged
merged 4 commits into from
Apr 16, 2024
Merged

SLB-304: Hero form #181

merged 4 commits into from
Apr 16, 2024

Conversation

mattiasimonato
Copy link
Contributor

Description of changes

Enhance PageHero with a Form section and add a dedicated storybook stories

How has this been tested?

  • Manually
  • Unit tests
  • Integration tests

@mattiasimonato mattiasimonato requested a review from pmelab April 11, 2024 14:54
@mattiasimonato
Copy link
Contributor Author

Hey @pmelab ,
this PR is failing on test:integration:drupal, I saw that it is related to the iframe, do you think this is happening because I'm using the same form url on BlockForm stories and Page stories? or because I am using BlockFrom component inside PageHero?

@pmelab pmelab force-pushed the SLB-304-hero-form branch from f87f954 to 9e42446 Compare April 16, 2024 08:10
pmelab
pmelab approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@pmelab pmelab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is good to go! Thanks!
I approved the chromatic screens even though the form is unstyled in there. I could not find an easy solution for injecting iframe.css in storybook globally, so i will leave this problem for later and create a new ticket.

@mattiasimonato mattiasimonato merged commit 6dc1872 into release Apr 16, 2024
4 checks passed
@mattiasimonato mattiasimonato deleted the SLB-304-hero-form branch April 16, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmelab pmelab pmelab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattiasimonato @pmelab