SLB-201: remove copy operations and streamline artefacts #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmelab
force-pushed
the
SLB-201-reduce-copying
branch
from
76d946e to
8a02150
Compare
Mistakenly added. They should be in @custom/schema
pmelab
force-pushed
the
SLB-201-reduce-copying
branch
from
1784b11 to
972dc30
Compare
pmelab
changed the title
Leksat
requested changes
Jan 24, 2024
Otherwise we loose proper cache handling by webpack.
To avoid a warning in Gatsby, which runs the file trough PostCSS again. It shouldn't do that, but there is no way to stop it.
Gatsby's style handling assumes every component has its own stylesheet, and it would add only the required styles to each page. With Tailwind though, we have only one global stylesheet, and adding it inline everywhere achieves the opposite.
Leksat
approved these changes
Jan 24, 2024
apps/website/gatsby-browser.ts
Outdated
| @@ -1,3 +1,5 @@ | |||
| import './node_modules/@custom/ui/build/styles.css'; | |||
There was a problem hiding this comment.
I saw that previously we imported it from both gatsby-browser and gatsby-ssr. Now it's gatsby-browser only. Not a mistake?
There was a problem hiding this comment.
It was a mistake before.
| @@ -38,6 +38,7 @@ export default { | |||
| siteUrl: process.env.NETLIFY_URL, | |||
| }, | |||
| plugins: [ | |||
| 'gatsby-plugin-uninline-styles', | |||
There was a problem hiding this comment.
This plugin does the same thing you did in the beginning? 🤔
There was a problem hiding this comment.
Ah, the filename already contains the hash. I see.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
@amazeelabs/gatsby-plugin-static-dirs(to be moved tosilverback-monoafter review)prepsteps generate files outside of the current page, and make the consuming packages load them vianode_modulesinstead.Motivation and context
How has this been tested?