Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webform styling #128

Merged
merged 6 commits into from
Jan 19, 2024
Merged

Webform styling #128

merged 6 commits into from
Jan 19, 2024

Conversation

Leksat
Copy link
Member

@Leksat Leksat commented Jan 15, 2024

Motivation and context

AmazeeLabs/silverback-mono#1347

How has this been tested?

  • Manually
  • Unit tests
  • Integration tests

There are integration tests in AmazeeLabs/silverback-mono#1484

Also: Chromatic 🎉

Main feature: no_css URL parameter which allows to export the "raw" form.
@Leksat Leksat force-pushed the SLB-178-webform-styling branch 2 times, most recently from c6e2ae8 to 79fc28b Compare January 15, 2024 18:24
Little hacky but allows
- fast turbo:prep re-runs during development
- no circular dependencies (could not put it into ui package prep step)
- reuse of e2e setup
@Leksat Leksat force-pushed the SLB-178-webform-styling branch from 79fc28b to 75f70ac Compare January 15, 2024 18:29
@Leksat Leksat requested a review from pmelab January 15, 2024 18:33
@Leksat Leksat marked this pull request as ready for review January 15, 2024 19:59
Copy link
Contributor

@pmelab pmelab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

One thing that came into my mind: This also allows us to storybook-ify pure Drupal projects! 🤯

tests/e2e/webform-snapshots/webforms.spec.ts Show resolved Hide resolved
@Leksat Leksat merged commit 94fcd88 into release Jan 19, 2024
4 checks passed
@Leksat Leksat deleted the SLB-178-webform-styling branch January 19, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants