Skip to content

Commit

Permalink
ci(SLB-219): switch to implicit browser downloads
Browse files Browse the repository at this point in the history
So each system has the right binaries.
  • Loading branch information
pmelab committed Apr 18, 2024
1 parent 2f58302 commit ef8a2bf
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 8 deletions.
6 changes: 0 additions & 6 deletions .github/actions/setup/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ runs:
- name: Install dependencies
shell: bash
run: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD=1 pnpm i

- name: Check formatting
shell: bash
Expand All @@ -45,8 +44,3 @@ runs:
with:
path: ~/.cache/ms-playwright
key: ${{ runner.os }}-playwright-${{ hashFiles('**/pnpm-lock.yaml') }}

- name: Install Playwright browsers
run: pnpm --filter "@custom-tests/e2e" download-browsers
shell: bash
if: steps.playwright-cache.outputs.cache-hit != 'true'
3 changes: 1 addition & 2 deletions tests/e2e/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@
"dev:decap": "playwright test --ui --config playwright.config.decap.ts",
"dev:drupal": "playwright test --ui --config playwright.config.drupal.ts",
"webform-snapshots": "playwright test --config playwright.config.webforms.ts",
"webform-snapshots:headed": "playwright test --config playwright.config.webforms.ts --headed",
"download-browsers": "playwright install chromium"
"webform-snapshots:headed": "playwright test --config playwright.config.webforms.ts --headed"
},
"devDependencies": {
"@amazeelabs/save-webpage": "^1.1.1",
Expand Down

0 comments on commit ef8a2bf

Please sign in to comment.