Skip to content

Commit

Permalink
chore(slb-306): resolving issues after merging conflicts
Browse files Browse the repository at this point in the history
  • Loading branch information
elistone committed May 10, 2024
1 parent 89e7248 commit b1dcdbc
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 53 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
fragment BlockInfoGrid on BlockInfoGrid {
items {
gridItems {
...BlockInfoGridItem
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/schema/src/schema.graphql
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ type BlockHorizontalSeparator @type(id: "custom/horizontal-separator") {
}

type BlockInfoGrid @type(id: "custom/info-grid") {
items: [BlockInfoGridItem]! @resolveEditorBlockChildren
gridItems: [BlockInfoGridItem]! @resolveEditorBlockChildren
}

type BlockInfoGridItem @default @value {
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/src/components/Organisms/PageDisplay.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export function PageDisplay(page: PageFragment) {
<br />
---
<br />
{block.items.map((item, index) => {
{block.gridItems.map((item, index) => {
return (
<>
<div key={index}>
Expand Down
52 changes: 2 additions & 50 deletions tests/schema/specs/blocks.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ test('Blocks', async () => {
}
}
... on BlockInfoGrid {
items {
gridItems: items {
icon
textContent {
markup
Expand Down Expand Up @@ -156,9 +156,6 @@ test('Blocks', async () => {
<p>A standalone paragraph with <strong><em>markup</em></strong> and <a href="/en/architecture" data-type="Content: Basic page" data-id="[numeric]" data-entity-type="node">link</a></p>
",
},
{
"__typename": "BlockHorizontalSeparator",
},
{
"__typename": "BlockMedia",
"caption": "Media image",
Expand All @@ -177,27 +174,6 @@ test('Blocks', async () => {
"__typename": "BlockForm",
"url": "http://127.0.0.1:8000/en/form/contact",
},
{
"__typename": "BlockImageWithText",
"image": {
"__typename": "MediaImage",
},
"imagePosition": "right",
"textContent": {
"__typename": "BlockMarkup",
"markup": "
<p>All kinds of allowed blocks</p>
<ul><li>bla</li></ul>
<h2 class="wp-block-custom-heading">Heading</h2>
<blockquote class="wp-block-quote"><p>Quote</p><cite>Citation</cite></blockquote>
<p></p>
",
},
},
{
"__typename": "BlockMarkup",
"markup": "
Expand Down Expand Up @@ -270,7 +246,7 @@ test('Blocks', async () => {
},
{
"__typename": "BlockInfoGrid",
"items": [
"gridItems": [
{
"cta": {
"icon": "ARROW",
Expand Down Expand Up @@ -306,32 +282,8 @@ test('Blocks', async () => {
<p>Call us to speak to a member of our team. We are always happy to help.</p>
<p><a href="tel:+16467865060">+1 (646) 786-5060</a></p>
"__typename": "BlockAccordion",
"items": [
{
"__typename": "BlockAccordionItemText",
"icon": "",
"textContent": {
"markup": "
<p>Incididunt laborum velit non proident nostrud velit. Minim excepteur ut aliqua nisi. Culpa laboris consectetur proident. Tempor esse ullamco et dolor proident id officia laborum voluptate nostrud elit dolore qui amet. Ex Lorem irure eu anim ipsum officia.</p>
",
},
"title": "With a single paragraph and no icon",
},
{
"__typename": "BlockAccordionItemText",
"icon": "arrow",
"textContent": {
"markup": "
<ul><li>Moitié-moitié</li><li>Fribourgeoise</li></ul>
<p>Incididunt laborum velit non proident nostrud velit. Minim excepteur ut aliqua nisi. Culpa laboris consectetur proident. Tempor esse ullamco et dolor proident id officia laborum voluptate nostrud elit dolore qui amet. Ex Lorem irure eu anim ipsum officia.</p>
",
},
"title": "With a list and a paragraph and arrow icon",
},
],
},
},
{
"cta": {
Expand Down

0 comments on commit b1dcdbc

Please sign in to comment.