Fix silverback-website builds #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leksat
force-pushed
the
see-if-it-fails-in-ci
branch
from
f4e3530 to
4cb53ee
Compare
Leksat
force-pushed
the
see-if-it-fails-in-ci
branch
from
09b4f3d to
3faf7bf
Compare
Leksat
changed the title
|
@pmelab FYI: I tried a workaround but it did not work. See the PR description. |
|
@pmelab also I'm not sure if the newly added |
|
@Leksat |
|
@pmelab yes, npm does that. But yarn does not. It does not support all of npm hooks: https://yarnpkg.com/advanced/lifecycle-scripts So the issue with local development is still open. |
|
How about this? #494 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
TypeScript and Webpack fail to resolve
@amazeelabs/gatsby-theme-coreand@amazeelabs/react-diwhen they are not compiled.Solution
Compile the mentioned packages during the monorepo initialization.
Solution which did not work
microsoft/TypeScript#21423 suggest a workaround:
It helps TypeScript, but does not work for webpack.