-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace mentions in message content with corresponding usernames #38
Replace mentions in message content with corresponding usernames #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me but I am not very familiar with Rust. Either way @AmaranthineCodices has to review it too before merging!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one concern about copying the content string. otherwise minor comments but looks good
…es-table Address problematic confusable (%)
Co-authored-by: Lily Brown <[email protected]>
Co-authored-by: Lily Brown <[email protected]>
…sponding usernames
Co-authored-by: Lily Brown <[email protected]>
Co-authored-by: Lily Brown <[email protected]>
…into enhance/clean-message-mentions
No description provided.