Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mentions in message content with corresponding usernames #38

Conversation

Archasion
Copy link
Contributor

No description provided.

Copy link

@Phalanxia Phalanxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but I am not very familiar with Rust. Either way @AmaranthineCodices has to review it too before merging!

Copy link
Owner

@AmaranthineCodices AmaranthineCodices left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one concern about copying the content string. otherwise minor comments but looks good

src/main.rs Outdated Show resolved Hide resolved
src/message.rs Outdated Show resolved Hide resolved
src/message.rs Outdated Show resolved Hide resolved
@AmaranthineCodices AmaranthineCodices merged commit 1a7d207 into AmaranthineCodices:main May 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants