Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce repeats in unpark_all_one_fast test #402

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Reduce repeats in unpark_all_one_fast test #402

merged 1 commit into from
Sep 22, 2023

Conversation

Darksonn
Copy link
Contributor

This test is causing failures in Android CI because it is too slow. I suggest reducing the number of repeats.

From our CI:

stdout: 
running 12 tests
test parking_lot::tests::unpark_one_one ... ok <0.499s>
test parking_lot::tests::hundred_unpark_all_one ... ok <0.568s>
test parking_lot::tests::unpark_one_fifty ... ok <0.706s>
test parking_lot::tests::unpark_one_fifty_then_fifty_all ... ok <1.489s>
test parking_lot::tests::unpark_one_hundred_fast ... ok <3.500s>
test parking_lot::tests::unpark_all_one ... ok <6.221s>
test parking_lot::tests::unpark_one_fifty_then_fifty_all_fast ... ok <10.103s>
test parking_lot::tests::unpark_all_hundred_fast ... ok <15.896s>
test parking_lot::tests::unpark_all_hundred ... ok <15.980s>
test parking_lot::tests::hundred_unpark_all_one_fast ... ok <20.817s>
test parking_lot::tests::unpark_one_one_fast ... ok <27.496s>
test parking_lot::tests::unpark_all_one_fast has been running for over 60 seconds

stderr: 
  Test run incomplete. Started 12 tests, finished 11

@Amanieu Amanieu merged commit 2b61f4c into Amanieu:master Sep 22, 2023
37 checks passed
@Darksonn Darksonn deleted the alice/speedup-unpark_all_one_fast branch September 22, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants