windows: impl ThreadParkerT / UnparkHandleT.
#396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, it was unused on Windows, but not Linux, because |
Windows was implementing the same functions directly on its `ThreadParker` and `UnparkHandle` (but with some functions not marked as `unsafe`). This changes the Windows implementation to match the other platforms. This fixes unused warnings about imports of those types when building on Windows.
waywardmonkeys
force-pushed
the
fix-unused-warnings
branch
from
f23d1b1
to
0699ffa
Compare
waywardmonkeys
changed the title
ThreadParkerT, UnparkHandleT.ThreadParkerT / UnparkHandleT.
|
The initial version of this patch did something different as I had misunderstood the problem. When building on Windows, there were some warnings about unused imports and I mistakenly throught the imports were unused rather than realizing that the actual issue was that the Windows code wasn't correctly implementing those traits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These imports were introduced in 2fb27d3 and were unused at the time and remain so.