Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging for parking_lot 0.9.0, _core 0.6.0 and lock_api 0.3.1 releases #159

Merged
merged 13 commits into from
Jul 14, 2019

Conversation

dekellum
Copy link
Contributor

This includes all necessary version changes and overhauls the CHANGELOG to show more recent releases for all three crates (parking_lot, parking_lot_core, lock_api). Before releasing, the top (TBD) should be replaced with the current date and tags for all crates added. I also request that you add the following tags to this repo retroactively:

git tag core-0.5.0 3259fd72e0d76e9c9a6f31ff41a996648fe9ccfa
git tag lock_api-0.1.5 2653619a613bc12dd6ab486f789d98956b65cdf0
git tag lock_api-0.2.0 3259fd72e0d76e9c9a6f31ff41a996648fe9ccfa
git tag lock_api-0.3.0 ace8280969b6362c3f3753506d90122c358de580

Fixes #158

@dekellum
Copy link
Contributor Author

dekellum commented Jul 11, 2019

The rendered CHANGELOG for preview.

@dekellum
Copy link
Contributor Author

The appveryor CI failure appears unrelated?

error occurred: Failed to find tool. Is `gcc.exe` installed? (see https://github.com/alexcrichton/cc-rs#compile-time-requirements for help)

@dekellum
Copy link
Contributor Author

master branch commit da16c2c is a fix to lock_api, so bumped version to 0.3.1, merged it here and updated CHANGELOG for that.

@dekellum dekellum changed the title Staging for parking_lot 0.9.0 and _core 0.6.0 releases Staging for parking_lot 0.9.0, _core 0.6.0 and lock_api 0.3.1 releases Jul 12, 2019
@dekellum
Copy link
Contributor Author

@Amanieu do you also want to yank lock_api 0.3.0, in light of the findings of da16c2c?

@Amanieu
Copy link
Owner

Amanieu commented Jul 12, 2019

@Amanieu do you also want to yank lock_api 0.3.0, in light of the findings of da16c2c?

Good point, I just yanked it.

@Amanieu Amanieu merged commit 58f9183 into Amanieu:master Jul 14, 2019
@Amanieu
Copy link
Owner

Amanieu commented Jul 14, 2019

Thanks a lot for the help! I have published new crate versions and added new tags.

@matklad
Copy link
Contributor

matklad commented Jul 15, 2019

I am a little worried by

Rust 1.31 may continue to work for normal use of these releases.

rand bumping msrv is definitely not a parking_lot fault, but still, the end result is unfortunate. Can I rely on parking_lot working with 1.31.0 or not? If I can, I'd be happy to send a PR that updates readme and adds a compile-only CI job for 1.31.0. I am also not against bumping msrv of reversed deps to 1.32.0, it's just unclear what is the current stance :)

@Amanieu
Copy link
Owner

Amanieu commented Jul 15, 2019

Yes, parking_lot should work fine on 1.31. It's just that the tests don't compile because of rand (which is only a dev-dependency).

I am happy to accept a PR to clarify this in the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release new parking_lot_core?
3 participants