Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dev install for @o3r/pipeline #2726

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

vscaiceanu-1a
Copy link
Member

Proposed change

The pipeline package should be added as a dev dependency.

We should reflect if this is the case for other packages as well.

@vscaiceanu-1a vscaiceanu-1a requested a review from a team as a code owner January 23, 2025 09:56
Copy link

nx-cloud bot commented Jan 23, 2025

View your CI Pipeline Execution ↗ for commit 99b3ad0.

Command Status Duration Result
nx run-many --target=test-int ✅ Succeeded 54m 26s View ↗
nx run-many --target=test-e2e ✅ Succeeded 10m View ↗
nx run-many --target=build --projects=eslint-pl... ✅ Succeeded 1s View ↗
nx run-many --target=publish --nx-bail --userco... ✅ Succeeded 1m 49s View ↗
nx run-many --target=build ✅ Succeeded 16m 24s View ↗
nx affected --target=lint ✅ Succeeded 3m 4s View ↗
nx affected --target=test --collectCoverage ✅ Succeeded 47s View ↗
nx affected --target=package-github-action ✅ Succeeded 1m 57s View ↗
Additional runs (3) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-01-24 12:04:56 UTC

@github-actions github-actions bot added documentation Improvements or additions to documentation project:@o3r/pipeline labels Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.36%. Comparing base (eabb580) to head (99b3ad0).
Report is 16 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sdo-1A
sdo-1A previously approved these changes Jan 23, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not have changes on github-actions

@@ -94,33 +94,6 @@ FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
IN THE SOFTWARE.

@o3r/new-version
Copyright Amadeus SAS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not be removed

@vscaiceanu-1a vscaiceanu-1a added this pull request to the merge queue Jan 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 24, 2025
@vscaiceanu-1a vscaiceanu-1a added this pull request to the merge queue Jan 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants