Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: renovate exception #2716

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: renovate exception #2716

wants to merge 1 commit into from

Conversation

kpanot
Copy link
Contributor

@kpanot kpanot commented Jan 21, 2025

Proposed change

fix: codecov version raising an exception on mend.io (see mend.io dashboard)
fix: renovate node version rule to activate on main branches

Related issues

- No issue associated -

@kpanot kpanot requested a review from a team as a code owner January 21, 2025 17:54
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 21, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 87988ee.

Command Status Duration Result
nx run-many --target=test-e2e ✅ Succeeded 9m 49s View ↗
nx run-many --target=test-int ✅ Succeeded 4s View ↗
nx run-many --target=build --projects=eslint-pl... ✅ Succeeded <1s View ↗
nx run-many --target=publish --nx-bail --userco... ✅ Succeeded 1m 48s View ↗
nx affected --target=test --collectCoverage ✅ Succeeded 1s View ↗
nx run ama-sdk-schematics:build-swagger ✅ Succeeded <1s View ↗
nx run-many --target=documentation ✅ Succeeded 1m 19s View ↗
nx run-many --target=build ✅ Succeeded 24s View ↗
Additional runs (3) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-01-22 07:00:06 UTC

@github-actions github-actions bot added the bug Something isn't working label Jan 21, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.33%. Comparing base (279f894) to head (87988ee).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kpanot kpanot force-pushed the bugfix/renovate-rule branch 2 times, most recently from b123e02 to 0a9bf93 Compare January 22, 2025 06:40
@kpanot
fix: codecov version raising an exception on mend.io
87988ee 
fix: renovate node version rule to activate on
@kpanot kpanot force-pushed the bugfix/renovate-rule branch from 0a9bf93 to 87988ee Compare January 22, 2025 06:42
fpaul-1A
fpaul-1A reviewed Jan 22, 2025
View reviewed changes
tools/renovate/managers/github-node-version.json5
"master",
"develop"
],
"enable": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is that needed? Isn't enabled by default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nop, in base we disable the major update on these branches.
(Which may be an issue in trunk-dev branching model :S)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough, might be a good idea to put the stuff related to branching model in a separate preset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpaul-1A fpaul-1A fpaul-1A approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpanot @fpaul-1A