Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chrome-devtools): add a panel to see the current value of all available facts #2685

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(chrome-devtools): add a panel to see the current value of all available facts #2685

wants to merge 1 commit into from
+326 −195

Conversation

fpaul-1A
Copy link
Contributor

Proposed change

image
image

Related issues

- No issue associated -

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 13, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 64fc196.

Command Status Duration Result
nx run-many --target=test-int ✅ Succeeded 12m 12s View ↗
nx run-many --target=test-e2e ✅ Succeeded 11m 29s View ↗
nx run-many --target=build --projects=eslint-pl... ✅ Succeeded 1s View ↗
nx run-many --target=publish --nx-bail --userco... ✅ Succeeded 1m 50s View ↗
nx run-many --target=build ✅ Succeeded 4m 27s View ↗
nx affected --target=test --collectCoverage ✅ Succeeded 53s View ↗
nx run-many --target=documentation ✅ Succeeded 1m 20s View ↗
nx affected --target=lint ✅ Succeeded 1m 58s View ↗
Additional runs (3) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-01-22 17:28:29 UTC

@fpaul-1A fpaul-1A force-pushed the feat/devtools-facts-snapshot branch 2 times, most recently from 4175037 to 3fca27f Compare January 22, 2025 14:08
@codecov Codecov
Copy link

codecov bot commented Jan 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.77%. Comparing base (b6b0ae6) to head (64fc196).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fpaul-1A fpaul-1A changed the title [draft] feat(chrome-devtools): add a panel to see the current value of all available facts feat(chrome-devtools): add a panel to see the current value of all available facts Jan 22, 2025
@fpaul-1A fpaul-1A marked this pull request as ready for review January 22, 2025 14:29
@fpaul-1A fpaul-1A requested a review from a team as a code owner January 22, 2025 14:29
@fpaul-1A fpaul-1A force-pushed the feat/devtools-facts-snapshot branch from 3fca27f to 980e5c8 Compare January 22, 2025 15:48
@fpaul-1A fpaul-1A force-pushed the feat/devtools-facts-snapshot branch from 980e5c8 to 64fc196 Compare January 22, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthieu-crouzet matthieu-crouzet matthieu-crouzet left review comments

@kpanot kpanot kpanot left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request project:@ama-sdk/schematics project:@o3r/chrome-devtools project:@o3r/core project:@o3r/eslint-config project:@o3r/eslint-config-otter project:@o3r/rules-engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Exposed facts in the o3r debug panel
3 participants
@fpaul-1A @kpanot @matthieu-crouzet