Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint): provide default ignores when adding @o3r/eslint-config #2677

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

matthieu-crouzet
Copy link
Contributor

Proposed change

Ease the usage of ESLint by providing default ignores when adding @o3r/eslint-config

Related issues

- No issue associated -

@matthieu-crouzet matthieu-crouzet requested a review from a team as a code owner January 8, 2025 15:47
@matthieu-crouzet matthieu-crouzet changed the base branch from main to release/11.6.0-rc January 8, 2025 15:48
Copy link

nx-cloud bot commented Jan 8, 2025

View your CI Pipeline Execution ↗ for commit 20e4dbe.

Command Status Duration Result
nx run-many --target=test-int ✅ Succeeded 23m 33s View ↗
nx run-many --target=build --projects=eslint-pl... ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-09 08:51:50 UTC

@github-actions github-actions bot added bug Something isn't working project:@o3r/eslint-config labels Jan 8, 2025
@matthieu-crouzet matthieu-crouzet force-pushed the fix/eslint-default-ignores branch from 2eb8538 to af41f0c Compare January 8, 2025 16:05
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.13%. Comparing base (168e709) to head (20e4dbe).
Report is 3 commits behind head on release/11.6.0-rc.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthieu-crouzet matthieu-crouzet merged commit 0bf643c into release/11.6.0-rc Jan 9, 2025
36 checks passed
@matthieu-crouzet matthieu-crouzet deleted the fix/eslint-default-ignores branch January 9, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working project:@o3r/eslint-config
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants