Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): align peer deps for eslint #2673

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

matthieu-crouzet
Copy link
Contributor

Proposed change

We are still supporting ESLint 8.57 😄

Related issues

- No issue associated -

@matthieu-crouzet matthieu-crouzet requested a review from a team as a code owner January 8, 2025 08:04
Copy link

nx-cloud bot commented Jan 8, 2025

View your CI Pipeline Execution ↗ for commit 2e8cad8.

Command Status Duration Result
nx run-many --target=test-int ✅ Succeeded 57m 27s View ↗
nx run-many --target=build --projects=eslint-pl... ✅ Succeeded 1s View ↗
nx run-many --target=test-e2e ✅ Succeeded 1m 50s View ↗
nx run-many --target=publish --nx-bail --userco... ✅ Succeeded 39s View ↗
nx run-many --target=build ✅ Succeeded 16m 19s View ↗
nx affected --target=lint --base=remotes/origin... ✅ Succeeded 14m 53s View ↗
nx affected --target=test --cacheDirectory=D:\a... ✅ Succeeded 9m 56s View ↗
nx affected --target=test --cacheDirectory=/hom... ✅ Succeeded 7m 47s View ↗
Additional runs (4) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-01-08 09:33:12 UTC

@github-actions github-actions bot added bug Something isn't working project:@o3r/schematics labels Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.05%. Comparing base (f10c0c3) to head (2e8cad8).
Report is 8 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthieu-crouzet matthieu-crouzet added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit 78cfcbb Jan 8, 2025
38 checks passed
@matthieu-crouzet matthieu-crouzet deleted the fix/peer-dep-on-eslint branch January 8, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working project:@o3r/schematics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants