Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(design): remove expectOverride on CSS causing runtime issue #2664

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

kpanot
Copy link
Contributor

@kpanot kpanot commented Jan 6, 2025

Proposed change

fix(design): remove expectOverride on CSS causing runtime issue
This feature can not be implemented with CSS Variable currently

Related issues

- No issue associated -

@kpanot kpanot requested a review from a team as a code owner January 6, 2025 13:41
Copy link

nx-cloud bot commented Jan 6, 2025

View your CI Pipeline Execution ↗ for commit a021ea2.

Command Status Duration Result
nx run-many --target=test-int ✅ Succeeded 3m 59s View ↗
nx run-many --target=build --projects=eslint-pl... ✅ Succeeded <1s View ↗
nx run-many --target=test-e2e ✅ Succeeded 1m 51s View ↗
nx run-many --target=publish --nx-bail --userco... ✅ Succeeded 35s View ↗
nx run-many --target=build ✅ Succeeded 2m 1s View ↗
nx run-many --target=documentation ✅ Succeeded 1m 17s View ↗
nx affected --target=test --cacheDirectory=D:\a... ✅ Succeeded 22s View ↗
nx run ama-sdk-schematics:build-swagger ✅ Succeeded <1s View ↗
Additional runs (4) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-01-08 01:10:07 UTC

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.81%. Comparing base (c4ec94c) to head (a021ea2).
Report is 22 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fpaul-1A
fpaul-1A previously approved these changes Jan 7, 2025
sdo-1A
sdo-1A previously approved these changes Jan 7, 2025
@kpanot kpanot dismissed stale reviews from sdo-1A and fpaul-1A via 034808f January 7, 2025 14:26
@kpanot kpanot force-pushed the bugfix/design-token-expect-override branch from e46a38f to 034808f Compare January 7, 2025 14:26
yarn.lock Outdated Show resolved Hide resolved
@kpanot kpanot force-pushed the bugfix/design-token-expect-override branch from 034808f to a021ea2 Compare January 8, 2025 00:49
@kpanot kpanot added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit e116ac5 Jan 8, 2025
37 checks passed
@kpanot kpanot deleted the bugfix/design-token-expect-override branch January 8, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants