feat: clean up deprecated items for Otter v12 #2642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 18470a5.
☁️ Nx Cloud last updated this comment at |
github-actions
bot
added
enhancement
sdo-1A
changed the title
fpaul-1A
reviewed
Jan 7, 2025
fpaul-1A
reviewed
Jan 7, 2025
fpaul-1A
reviewed
Jan 7, 2025
packages/@o3r/rules-engine/src/devkit/rules-engine-devtools.console.service.ts
Outdated
Show resolved
Hide resolved
fpaul-1A
reviewed
Jan 7, 2025
packages/@o3r/rules-engine/src/devkit/rules-engine-devtools.service.ts
Outdated
Show resolved
Hide resolved
kpanot
reviewed
Jan 8, 2025
sdo-1A
force-pushed
the
feat/cleanup-deprecated
branch
6 times, most recently
from
ece7635 to
e104ae1
Compare
fpaul-1A
previously approved these changes
Jan 9, 2025
Comment on lines
1
to
11
| import { | ||
| chain, | ||
| Rule, | ||
| SchematicContext, | ||
| Tree, | ||
| } from '@angular-devkit/schematics'; | ||
| import { | ||
| createSchematicWithMetricsIfInstalled, | ||
| ImportsMapping, | ||
| updateImports, | ||
| } from '@o3r/schematics'; |
There was a problem hiding this comment.
Suggested change
| import { | |
| chain, | |
| Rule, | |
| SchematicContext, | |
| Tree, | |
| } from '@angular-devkit/schematics'; | |
| import { | |
| createSchematicWithMetricsIfInstalled, | |
| ImportsMapping, | |
| updateImports, | |
| } from '@o3r/schematics'; | |
| import { | |
| chain, | |
| type Rule, | |
| type SchematicContext, | |
| type Tree, | |
| } from '@angular-devkit/schematics'; | |
| import { | |
| createSchematicWithMetricsIfInstalled, | |
| type ImportsMapping, | |
| updateImports, | |
| } from '@o3r/schematics'; |
matthieu-crouzet
previously approved these changes
Jan 9, 2025
sdo-1A
force-pushed
the
feat/cleanup-deprecated
branch
from
e104ae1 to
18470a5
Compare
fpaul-1A
approved these changes
Jan 9, 2025
vscaiceanu-1a
approved these changes
Jan 9, 2025
matthieu-crouzet
approved these changes
Jan 9, 2025
kpanot
reviewed
Jan 10, 2025
Comment on lines
+19
to
+26
| "source", | ||
| "^source", | ||
| "{projectRoot}/schemas/*.json", | ||
| "{projectRoot}/scss/**/*", | ||
| "!{projectRoot}/scss/**/*.spec.ts", | ||
| "{projectRoot}/assets/**", | ||
| "{projectRoot}/_index.scss", | ||
| "{projectRoot}/_otter-theme.scss" |
There was a problem hiding this comment.
Suggested change
| "source", | |
| "^source", | |
| "{projectRoot}/schemas/*.json", | |
| "{projectRoot}/scss/**/*", | |
| "!{projectRoot}/scss/**/*.spec.ts", | |
| "{projectRoot}/assets/**", | |
| "{projectRoot}/_index.scss", | |
| "{projectRoot}/_otter-theme.scss" | |
| "source", | |
| "^source", | |
| "schemas", | |
| "{projectRoot}/scss/**/*.scss", | |
| "{projectRoot}/assets/**", | |
| "{projectRoot}/_index.scss", | |
| "{projectRoot}/_otter-theme.scss" |
(maybe it could be interesting to add a namedInput for {projectRoot}/assets/** as it is used in several places)
There was a problem hiding this comment.
I will do this in a separate PR
amadeus-pmeneguzzi
approved these changes
Jan 10, 2025
sdo-1A
added a commit
that referenced
this pull request
Jan 15, 2025
## Proposed change Small fix as a follow up of this comment: #2642 (comment) ## Related issues <!-- Please make sure to follow the [contribution guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md) --> *- No issue associated -* <!-- * 🐛 Fix #issue --> <!-- * 🐛 Fix resolves #issue --> <!-- * 🚀 Feature #issue --> <!-- * 🚀 Feature resolves #issue --> <!-- *Pull Request #issue -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Remove deprecated items from Otter v12
TO DO:
inputFactsfrom@o3r/rules-enginevariablefrom@o3r/styling@o3r/dev-toolsRelated issues
- No issue associated -