fix: base code navigation on webcontainer instead of project initial value #2590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 22ed14a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
fpaul-1A
reviewed
Dec 13, 2024
apps/showcase/src/components/training/code-editor-view/code-editor-view.component.html
Show resolved
Hide resolved
fpaul-1A
reviewed
Dec 13, 2024
apps/showcase/src/components/training/code-editor-view/code-editor-view.component.ts
Outdated
Show resolved
Hide resolved
fpaul-1A
reviewed
Dec 13, 2024
apps/showcase/src/services/webcontainer/webcontainer.service.ts
Outdated
Show resolved
Hide resolved
…value Project only contains the description of the exercise and does not reflect the trainee changes
cpaulve-1A
force-pushed
the
fix/various-fixes
branch
from
d615263 to
22ed14a
Compare
fpaul-1A
approved these changes
Dec 13, 2024
matthieu-crouzet
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Project only contains the description of the exercise and does not reflect the trainee changes.
The file list should reflect the webcontainer state
Fixes also e2e tests and add a prefix for training directories to avoid name conflicts
Related issues
- No issue associated -