Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove pattern for ref property in localization.metadata.schema.json #2582

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

guillaumerochelle
Copy link
Contributor

@guillaumerochelle guillaumerochelle commented Dec 12, 2024

There is no point validating the ref if we don't validate the key.

@guillaumerochelle guillaumerochelle requested a review from a team as a code owner December 12, 2024 08:31
@github-actions github-actions bot added bug Something isn't working project:@o3r/localization labels Dec 12, 2024
@guillaumerochelle guillaumerochelle changed the base branch from release/11.3 to release/11.5 December 12, 2024 08:36
@mrednic-1A mrednic-1A force-pushed the bugfix/localization-metadata-schema branch from b7a8f96 to 34ba147 Compare December 12, 2024 09:35
@mrednic-1A mrednic-1A enabled auto-merge December 12, 2024 09:35
@amadeus-pmeneguzzi
Copy link

I approve this change !

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (e1f959b) to head (34ba147).
Report is 2 commits behind head on release/11.5.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrednic-1A mrednic-1A merged commit 681ec8b into release/11.5 Dec 12, 2024
26 of 27 checks passed
@mrednic-1A mrednic-1A deleted the bugfix/localization-metadata-schema branch December 12, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working project:@o3r/localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants