feat(config): generate default config with readonly and as const

[matthieu-crouzet]

Related issues

🐛 Fix #2530

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit cea1241. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 11 targets

• nx run-many --target=test-int --parallel 3
• nx run-many --target=test-e2e --parallel 3
• nx run-many --target=build --projects=eslint-plugin --parallel 3
• nx run-many --target=publish --parallel 3 --nx-bail --userconfig .verdaccio/conf/.npmrc-logged --tag=latest --@o3r:registry=http://127.0.0.1:4873 --@ama-sdk:registry=http://127.0.0.1:4873 --@ama-terasu:registry=http://127.0.0.1:4873 --@o3r-training:registry=http://127.0.0.1:4873
• nx affected --target=lint --parallel 3 --base=remotes/origin/main --configuration ci
• nx run-many --target=documentation --parallel 3
• nx run-many --target=build --parallel 3
• nx affected --target=test --parallel 3 --cacheDirectory=D:\a\otter\otter/.cache/jest --base=remotes/origin/main --collectCoverage
• nx run ama-sdk-schematics:build-swagger
• nx affected --target=test --parallel 3 --cacheDirectory=/home/runner/work/otter/otter/.cache/jest --base=remotes/origin/main --collectCoverage
• nx run-many --target=build-swagger --parallel 3

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

Attention: Patch coverage is 90.32258% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.87%. Comparing base (28ffcb9) to head (cea1241).
Report is 9 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...alization/schematics/add-localization-key/index.ts	50.00%	1 Missing and 1 partial ⚠️
...or/helpers/component/component-config.extractor.ts	75.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kpanot]

To handle different linter rule guidelines it can be an easy fix to turn the ; non-mandatory :

Suggested change

	const regexp = /translations\s*:\s*(?:Readonly<)?([A-Z][\w]*)(?:>)?\s*=\s*({[^;]+})\s*(as\s*const)?\s*;/g;
	const regexp = /translations\s*:\s*(?:Readonly<)?([A-Z][\w]*)(?:>)?\s*=\s*({[^;]+})\s*(as\s*const)?\s*;?/g;

[matthieu-crouzet]

It's more difficult to detect the end of the object then
; is used before in the regexp for that ({[^;]+})

[kpanot]

Then I propose:

/translations\s*:\s*(?:Readonly<)?([A-Z][\w]*)(?:>)?\s*=\s*({(?:[^:]+:\s*(?:".*"|'.*'|\s*,\s*))*\s*})\s*(as\s*const)?\s*;?/g

[matthieu-crouzet]

Does not work for complex object like the one in this example
https://regex101.com/r/2HTPCa/1

[kpanot]

Indeed but it is working for localisation, which is what you want to parse, don't you?
(And it does support ; within the translation key even if I am not sure we do support it farer in the extractor 😅)

[matthieu-crouzet]

Yes my point was that I have the same issue (and same regexp, expect the starting point) for configuration