-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate(rules-engine): actionHandlers will become protected in v13 #2518
Merged
matthieu-crouzet
merged 1 commit into
main
from
deprecate-action-handlers-access-specifier
Nov 27, 2024
Merged
deprecate(rules-engine): actionHandlers will become protected in v13 #2518
matthieu-crouzet
merged 1 commit into
main
from
deprecate-action-handlers-access-specifier
Nov 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
deprecate
The issue or pull request involves code deprecation
project:@o3r/rules-engine
project:@o3r/showcase
labels
Nov 26, 2024
kpanot
reviewed
Nov 26, 2024
packages/@o3r/rules-engine/src/services/runner/rules-engine.runner.service.ts
Show resolved
Hide resolved
fpaul-1A
reviewed
Nov 26, 2024
packages/@o3r/rules-engine/src/services/runner/rules-engine.runner.service.ts
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files☔ View full report in Codecov by Sentry. |
matthieu-crouzet
force-pushed
the
deprecate-action-handlers-access-specifier
branch
from
November 26, 2024 16:39
d3b7549
to
0b88845
Compare
kpanot
previously approved these changes
Nov 27, 2024
fpaul-1A
previously approved these changes
Nov 27, 2024
packages/@o3r/rules-engine/schematics/ng-update/v11.6/use-register-action-handlers.spec.ts
Outdated
Show resolved
Hide resolved
packages/@o3r/rules-engine/schematics/ng-update/v11.6/use-register-action-handlers.ts
Outdated
Show resolved
Hide resolved
matthieu-crouzet
dismissed stale reviews from fpaul-1A and kpanot
via
November 27, 2024 08:01
08cdf7a
matthieu-crouzet
force-pushed
the
deprecate-action-handlers-access-specifier
branch
from
November 27, 2024 08:01
0b88845
to
08cdf7a
Compare
fpaul-1A
previously approved these changes
Nov 27, 2024
matthieu-crouzet
force-pushed
the
deprecate-action-handlers-access-specifier
branch
from
November 27, 2024 08:24
08cdf7a
to
ff5a8bd
Compare
fpaul-1A
reviewed
Nov 27, 2024
packages/@o3r/rules-engine/schematics/ng-update/v11.6/use-register-action-handlers.spec.ts
Show resolved
Hide resolved
matthieu-crouzet
force-pushed
the
deprecate-action-handlers-access-specifier
branch
from
November 27, 2024 08:39
ff5a8bd
to
7a22714
Compare
fpaul-1A
approved these changes
Nov 27, 2024
kpanot
approved these changes
Nov 27, 2024
matthieu-crouzet
deleted the
deprecate-action-handlers-access-specifier
branch
November 27, 2024 14:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
deprecate
The issue or pull request involves code deprecation
project:@o3r/rules-engine
project:@o3r/showcase
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
It's not a good practice to expose a
Set
.I added a method
registerActionHandlers
to replace the usage ofactionHandlers.add(...)
.It will be future proof if we want to do something else when an action handler is registered.