Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate(rules-engine): actionHandlers will become protected in v13 #2518

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

matthieu-crouzet
Copy link
Contributor

Proposed change

It's not a good practice to expose a Set.
I added a method registerActionHandlers to replace the usage of actionHandlers.add(...).
It will be future proof if we want to do something else when an action handler is registered.

@matthieu-crouzet matthieu-crouzet requested a review from a team as a code owner November 26, 2024 15:38
@github-actions github-actions bot added deprecate The issue or pull request involves code deprecation project:@o3r/rules-engine project:@o3r/showcase labels Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.03%. Comparing base (1dbf243) to head (7a22714).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...src/services/runner/rules-engine.runner.service.ts 0.00% 4 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthieu-crouzet matthieu-crouzet force-pushed the deprecate-action-handlers-access-specifier branch from d3b7549 to 0b88845 Compare November 26, 2024 16:39
kpanot
kpanot previously approved these changes Nov 27, 2024
@matthieu-crouzet matthieu-crouzet dismissed stale reviews from fpaul-1A and kpanot via 08cdf7a November 27, 2024 08:01
@matthieu-crouzet matthieu-crouzet force-pushed the deprecate-action-handlers-access-specifier branch from 0b88845 to 08cdf7a Compare November 27, 2024 08:01
fpaul-1A
fpaul-1A previously approved these changes Nov 27, 2024
@matthieu-crouzet matthieu-crouzet force-pushed the deprecate-action-handlers-access-specifier branch from ff5a8bd to 7a22714 Compare November 27, 2024 08:39
@matthieu-crouzet matthieu-crouzet added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit 8dd1971 Nov 27, 2024
36 checks passed
@matthieu-crouzet matthieu-crouzet deleted the deprecate-action-handlers-access-specifier branch November 27, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecate The issue or pull request involves code deprecation project:@o3r/rules-engine project:@o3r/showcase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants