Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setup Nx Cloud Id for PAT support #2410

Merged
merged 1 commit into from
Nov 6, 2024
Merged

chore: setup Nx Cloud Id for PAT support #2410

merged 1 commit into from
Nov 6, 2024

Conversation

kpanot
Copy link
Contributor

@kpanot kpanot commented Nov 6, 2024

Proposed change

Setup Nx Cloud Id for PAT support
See https://nx.dev/ci/recipes/security/personal-access-tokens for details

Related issues

- No issue associated -

@kpanot kpanot requested a review from a team as a code owner November 6, 2024 07:44
nx.json Show resolved Hide resolved
@kpanot kpanot force-pushed the feature/nx-cloud branch 5 times, most recently from e556113 to e35aea5 Compare November 6, 2024 11:48

jobs:
# Check the integrity of yarn lock
yarn_lock_check:
runs-on: ubuntu-latest
env:
NX_SKIP_NX_CACHE: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to your change but don't we want the Nx cache for this step?

Copy link
Contributor Author

@kpanot kpanot Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is required by nx-cloud runner when run in CI.
cf: https://github.com/AmadeusITGroup/otter/actions/runs/11702511447/job/32590842412

edit:
I completely misread your question, sorry about that.
It would actually speed up the postinstall process, we may want it. I will add it in another PR, I keep it as it currently is in this PR

@kpanot kpanot added this pull request to the merge queue Nov 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 6, 2024
@kpanot kpanot added this pull request to the merge queue Nov 6, 2024
Merged via the queue into main with commit 5070b72 Nov 6, 2024
29 checks passed
@kpanot kpanot deleted the feature/nx-cloud branch November 6, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants