Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(svg-loader): new package #54

Open
wants to merge 8 commits into
base: next
Choose a base branch
from
Open

feat(svg-loader): new package #54

wants to merge 8 commits into from

Conversation

njfamirm
Copy link
Member

Description

@njfamirm njfamirm added the new-feature New features or options. label Feb 24, 2024
@njfamirm njfamirm self-assigned this Feb 24, 2024
@njfamirm njfamirm requested a review from alimd as a code owner February 24, 2024 13:11
alimd
alimd requested changes Feb 27, 2024
View reviewed changes
Copy link
Member

@alimd alimd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

لطفاً اسم پکیج svg-loader باشه

@njfamirm njfamirm changed the title feat(icon-loader): new package feat(svg-loader): new package Feb 28, 2024
@njfamirm njfamirm requested a review from alimd March 4, 2024 08:00
alimd
alimd reviewed Mar 4, 2024
View reviewed changes
packages/svg-loader/README.md
```js
// .eleventy.config.js

const {iconLoader} = require('@alwatr/svg-loader');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!

alimd
alimd reviewed Mar 4, 2024
View reviewed changes
packages/svg-loader/svg-loader.cjs
* @param {string} customClass custom class added to svg span container
* @returns {Promise<string>} svg content inside of a span
*/
async function iconLoader(icon, customClass = '') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!

alimd
alimd requested changes Mar 4, 2024
View reviewed changes
Copy link
Member

@alimd alimd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

css?!
function name?!

@alimd
Copy link
Member

alimd commented Mar 27, 2024

به نظرم یک پکیج باید اینجا باشه که یک محتوای متنی رو از داخل پکیج لود کنه با قابلیت کش
میتونه اسمش svg-loader باشه یا ترجیحا اسمی جنرال تر
حالا تو پروژه آیکون یک پکیج باشه برای icon-loader با کلاس و ...
و یک پکیج دیگه برای پلاگین 11ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimd alimd alimd requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@njfamirm njfamirm

Labels
new-feature New features or options.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@njfamirm @alimd