Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nano-server): getRemoteAddress, requireClientId #799

Merged
merged 3 commits into from
Feb 11, 2023
Merged

Conversation

alimd
Copy link
Member

@alimd alimd commented Feb 11, 2023

No description provided.

@alimd alimd added new-feature New features or options. bugfix Inconsistencies or issues which will cause a problem for users or implementors. labels Feb 11, 2023
@alimd alimd requested a review from njfamirm February 11, 2023 01:03
@alimd alimd self-assigned this Feb 11, 2023
@alimd alimd merged commit 68ef633 into next Feb 11, 2023
Comment on lines +614 to +618
throw {
ok: false,
statusCode: 401,
errorCode: 'client_denied',
};

Check failure

Code scanning / ESLint

Disallow throwing literals as exceptions

Expected an error object to be thrown.
@alimd alimd deleted the fix/nano-server branch February 11, 2023 01:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementors. new-feature New features or options.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant