Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui-kit/icon-box): new component #665

Merged
merged 11 commits into from
Jan 18, 2023
Merged

feat(ui-kit/icon-box): new component #665

merged 11 commits into from
Jan 18, 2023

Conversation

MM25Zamanian
Copy link
Contributor

PR Checklist

@MM25Zamanian MM25Zamanian added the enhancement Enhancement of the code, not introducing new features. label Jan 16, 2023
@MM25Zamanian MM25Zamanian self-assigned this Jan 16, 2023
@MM25Zamanian MM25Zamanian requested a review from alimd as a code owner January 16, 2023 18:53
alimd
alimd requested changes Jan 18, 2023
View reviewed changes
Copy link
Member

@alimd alimd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ساختار property ها باید تغییر کنه به یک آبجکی پایه و ساده

alimd
alimd approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@alimd alimd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

دقیقا ۲ ساعت درست کردن جزییات این کامپوننت ساده طول کشید!

@alimd alimd enabled auto-merge January 18, 2023 17:13
@MM25Zamanian
Copy link
Contributor Author

دقیقا ۲ ساعت درست کردن جزییات این کامپوننت ساده طول کشید!

میشه بپرسم کجای این موضوع تقصیر منه؟
کل زمان ساختش یک ساعت نشد

چرا باید جزییاتش دوساعت طول بکشه؟

@alimd alimd merged commit d6343f6 into next Jan 18, 2023
@alimd alimd deleted the feat/icon-box branch January 18, 2023 17:22
@alimd
Copy link
Member

alimd commented Jan 18, 2023

میشه بپرسم کجای این موضوع تقصیر منه؟

@MM25Zamanian
جنبه گله نداشت
ولی از بابی که میپرسی در خصوصی میزیتو توضیح دادم

@github-actions
Copy link

Pull Request closed and locked due to lack of activity.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alimd alimd alimd approved these changes

Assignees

@MM25Zamanian MM25Zamanian

Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MM25Zamanian @alimd @njfamirm