fix(uniquely/flight-crawler): prevent set storage repeated #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njfamirm
added
minor
alimd
reviewed
Dec 21, 2022
alimd
reviewed
Dec 21, 2022
alimd
reviewed
Dec 21, 2022
alimd
reviewed
Dec 21, 2022
services/flight-crawler/src/crawl.ts
Outdated
| } | ||
| catch (err) { | ||
| logger.error('crawlAllJobs', 'crawling_failed', err); | ||
| } | ||
| } | ||
| // for updating meta | ||
| if (updated === false) await storageClient.set(jobList[jobKey[jobKey.length - 1]]); |
There was a problem hiding this comment.
خیلی حس ماستمالی دارم
یک روت نمیشه بهش اضافه کنیم برای اینجور مواقع!
There was a problem hiding this comment.
ساختار کوبی خب مگه برای همین نبود؟
یک متای مختص به همین رو باید ست کنیم
غیر از دیفالتا
alimd
approved these changes
Dec 22, 2022
|
Pull Request closed and locked due to lack of activity. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.