New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nano-server): handle utf8 reply issue #514

Merged

alimd merged 2 commits into next from fix/nano-server

Dec 18, 2022

Member

alimd commented Dec 18, 2022

بالاخره این باگ عوضی رو پیدا کردم 🎉

داستان اینجا بود که...

String.prototype.length does not account for the encoding that is used to convert the string into bytes.


          fix(nano-server): handle utf8 reply issue

33aa238

alimd added the bugfix label

alimd added this to the v0.x milestone

alimd requested a review from njfamirm

December 18, 2022 10:33

alimd self-assigned this

Contributor

satafti commented Dec 18, 2022 via email

😍😍😍

On Sun, 18 Dec 2022, 14:04 S. Ali Mihandoost, ***@***.***> wrote: بالاخره این باگ عوضی رو پیدا کردم 🎉 داستان اینجا بود که... v8 buffer <https://nodejs.org/api/buffer.html#static-method-bufferbytelengthstring-encoding> String.prototype.length does not account for the encoding that is used to convert the string into bytes. ------------------------------ You can view, comment on, or merge this pull request online at: #514 Commit Summary - 3906f70 <3906f70> chore(tsconfig): noImplicitAny - c40da9c <c40da9c> feat(storage-engine)!: enhance types, debug and access to `_storage` directly - 44b84f0 <44b84f0> feat(fetch): add AlwatrDocumentStorage type - b0b5478 <b0b5478> feat(fetch): serviceRequest - a6859ee <a6859ee> refactor(storage-client): rewrite with serviceRequest - ef7ca74 <ef7ca74> refactor(storage-client)!: rename getAll to getStorage - e86c9cd <e86c9cd> fix(storage-engine): work with new types - ca9a7bf <ca9a7bf> fix(storage-engine): AlwatrDocumentStorage - aac916b <aac916b> docs(storage-client): getStorage docs - 20df110 <20df110> fix(storage-client): build issue - d7bef2e <d7bef2e> refactor(comment)!: rename route /all to /storage - a65e6bd <a65e6bd> fix(flight-crawler): use getStorage - 2df46a9 <2df46a9> fix(storage-server)!: rename route /all to /storage - 047a95b <047a95b> refactor(ff-api): rename storageClient - 21b2361 <21b2361> fix(demo/storage-client): getStorage - 7f9b5e8 <7f9b5e8> Merge branch 'next' into feat/storage - c1ef85d <c1ef85d> fix(storage-client): import type - eaab2ae <eaab2ae> Merge branch 'feat/storage' of github.com:AliMD/alwatr into feat/storage - 4a8200c <4a8200c> feat(storage-client): more data validate on get - fc5fe8a <fc5fe8a> feat(storage-client): error codes - 4dbd79f <4dbd79f> fix(storage-engine): export type - ad24c81 <ad24c81> fix(fetch): remove extra _options - 441c2f8 <441c2f8> fix(storage-client): getStorage queryParameters - dbfc7ff <dbfc7ff> fix(fetch): enhance handle and report errors in serviceRequest - bd54b23 <bd54b23> chore(storage-server): update demo.http - 3edc550 <3edc550> refactor(demo): rename benchmark - 33aa238 <33aa238> fix(nano-server): handle utf8 reply issue File Changes (30 files <https://github.com/AliMD/alwatr/pull/514/files>) - *M* core/fetch/src/fetch.ts <https://github.com/AliMD/alwatr/pull/514/files#diff-e7e280cfd663214ee9168440f410e4b41112769117ec66c646bcf08b61e5e4a6> (45) - *M* core/fetch/src/type.ts <https://github.com/AliMD/alwatr/pull/514/files#diff-247d547ee0392fffb5ed30722e5c86d8e456b8b91e3904b0096f8b3e7df788aa> (2) - *M* core/nano-server/src/nano-server.ts <https://github.com/AliMD/alwatr/pull/514/files#diff-c0611d24c30a11fed90428c92285042c18530f130969eb7ac911efb7d46c9998> (27) - *M* core/storage-client/README.md <https://github.com/AliMD/alwatr/pull/514/files#diff-7a60cb0189846712abb66436803a5d8268cbbddd0d4d2179a5055507d2fa3b4f> (4) - *M* core/storage-client/src/storage-client.ts <https://github.com/AliMD/alwatr/pull/514/files#diff-69f178cde6ead97c759ac2aa983e320c86df5c04271d726be3a86869aee3ed57> (160) - *M* core/storage-engine/src/storage-engine.ts <https://github.com/AliMD/alwatr/pull/514/files#diff-3066257fb725779603fbda900c2ed1e98b91708ffa176cf35ee24d116e213976> (56) - *M* core/storage-engine/src/type.ts <https://github.com/AliMD/alwatr/pull/514/files#diff-ae41f198193aa5aedcb7a672ae9035586722d56c17282468287829a976fe6b8d> (15) - *M* demo/storage-client/benchmark.ts <https://github.com/AliMD/alwatr/pull/514/files#diff-c88c6ec55f4dfc72e5f6a2dc4fb3105f246c86233f92125d80e228419a571377> (2) - *M* demo/storage-client/index.ts <https://github.com/AliMD/alwatr/pull/514/files#diff-022eb46e53a66e7618bbadc260cff265708df856dd08c6705c5f362459879c9b> (2) - *R* demo/storage-engine/benchmark.ts <https://github.com/AliMD/alwatr/pull/514/files#diff-b69a688dd607387c0641ee149aa3f5a9efcd73d22c1b13d915422f68f5adf700> (0) - *M* services/comment/demo.http <https://github.com/AliMD/alwatr/pull/514/files#diff-09aa212c664f020e2076d7ce26805c2ca29f949e03fc17791a90a7dcf5dc9a4c> (2) - *M* services/comment/src/index.ts <https://github.com/AliMD/alwatr/pull/514/files#diff-ebdc191efe81f182bfea015879e2cb842bee78dd912f70842603b5b55433e34d> (2) - *R* services/comment/src/route/storage.ts <https://github.com/AliMD/alwatr/pull/514/files#diff-ea21c926a7be305d222834a7c575fa570586f564ee7108f04593f3dbc0a77bae> (15) - *M* services/flight-crawler/src/crawl.ts <https://github.com/AliMD/alwatr/pull/514/files#diff-8282a2d9f7f1cceae888d507c6d4602c8b900a7cb2873571507bfd023797a75a> (6) - *M* services/flight-crawler/src/lib/storage.ts <https://github.com/AliMD/alwatr/pull/514/files#diff-83563eb0edc9c1f6f88adde3bc30b2182c50ab2f2b19f01671ef91469bf7ce6a> (2) - *M* services/storage-server/demo.http <https://github.com/AliMD/alwatr/pull/514/files#diff-2faf5199b98723b53b1cf5305a6cc67e87da8a3cd239dca409c2c574e11dfa9e> (16) - *M* services/storage-server/src/index.ts <https://github.com/AliMD/alwatr/pull/514/files#diff-18c212188983a5c720f09fd2de6f401cc0f1ab2f843805f1e5b30b51330d3bad> (2) - *D* services/storage-server/src/route/all.ts <https://github.com/AliMD/alwatr/pull/514/files#diff-eaf4ea1d5fa20924f6a1a726c1ef3dcaa2093f76d01e19db9219b0cfbdefd441> (24) - *M* services/storage-server/src/route/delete.ts <https://github.com/AliMD/alwatr/pull/514/files#diff-6f3996f701417eafe7630f913cace92c4ec7cf1f1f25b512b943dc4164172cb2> (4) - *M* services/storage-server/src/route/get.ts <https://github.com/AliMD/alwatr/pull/514/files#diff-111adbe45b865873a1d7c781ab58a90ddc1209ca96055e7b23879167fce9fc40> (4) - *M* services/storage-server/src/route/has.ts <https://github.com/AliMD/alwatr/pull/514/files#diff-8a0d7eef2c2309866f39b1b9c165902dc0f70d6f732de61b3cbf0fbab0391ed6> (4) - *M* services/storage-server/src/route/keys.ts <https://github.com/AliMD/alwatr/pull/514/files#diff-f513bf3c145155650b4c64b20172d477012d11c0bcfa4a8031bcbf4f0f2eb421> (4) - *M* services/storage-server/src/route/patch.ts <https://github.com/AliMD/alwatr/pull/514/files#diff-0f584e73e78ad5a860b057825668644646ef78c08568c76787d6f16210a19934> (4) - *A* services/storage-server/src/route/storage.ts <https://github.com/AliMD/alwatr/pull/514/files#diff-6db2bc7fcd825c8f64acc0648dafff7d6b63bec6b9bf819558ec7f28e9138d1d> (21) - *M* tsconfig.base.json <https://github.com/AliMD/alwatr/pull/514/files#diff-0b280a445be167f54cd916c0718c952b8e0d4ca9621903d05eec25efd4c6ed6d> (2) - *M* uniquely/flight-finder-api/src/lib/storage.ts <https://github.com/AliMD/alwatr/pull/514/files#diff-eb0978be879be5bd01e9808ec31ae47cf07d0d037b92019db82d8feab3db9355> (2) - *M* uniquely/flight-finder-api/src/route/job/delete.ts <https://github.com/AliMD/alwatr/pull/514/files#diff-00f193637bf402205b6f7193bd62a5f3671a30a166fca4ea148931c7395ee156> (4) - *M* uniquely/flight-finder-api/src/route/job/get.ts <https://github.com/AliMD/alwatr/pull/514/files#diff-122a6e1f816790cfb287a980d834c92aa85acfe9bd695e3b8fe83cbad300cc2c> (7) - *M* uniquely/flight-finder-api/src/route/job/put.ts <https://github.com/AliMD/alwatr/pull/514/files#diff-605b167efee1990280c8a5a857a5992ddb30dad3647230a5865ee43c50208b9a> (6) - *M* uniquely/flight-finder-pwa/workbox-config.js <https://github.com/AliMD/alwatr/pull/514/files#diff-aecd330d782cf8c8ffdd307d3c0af07a0075933146f7f42f9925653070053ede> (3) Patch Links: - https://github.com/AliMD/alwatr/pull/514.patch - https://github.com/AliMD/alwatr/pull/514.diff — Reply to this email directly, view it on GitHub <#514>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAPSVHHDA62XVOHYZ3CI4ZDWN3SBVANCNFSM6AAAAAATCOMOKU> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

Member

njfamirm commented Dec 18, 2022

تبریک 👌🤩
خسته نباشید


          Merge branch 'next' into fix/nano-server

9c141c0

Member Author

alimd commented Dec 18, 2022

پول تمیز شد
حالا میتونید ببینی دقیقا مشکل چی بوده و چطور حل شد
جالب اینجاست که با این کار سرعت پاسخ به درخواست‌ها با حجم بالا چندید برابر شد و مصرف رم هم زیر بار زیاد خیلی کمتر میشه!

alimd merged commit 18fc6e5 into next

alimd deleted the fix/nano-server branch

December 18, 2022 13:36

njfamirm reviewed

View reviewed changes

Member

njfamirm left a comment

چقدر جذاب تر شد!

Member

njfamirm commented Dec 19, 2022

متوجه باگ نمیشم الیته

github-actions bot commented Dec 21, 2022

Pull Request closed and locked due to lack of activity.

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix