Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking-change: document object and server response types #436

Merged
merged 26 commits into from
Nov 28, 2022
Merged

breaking-change: document object and server response types #436

merged 26 commits into from
Nov 28, 2022

Conversation

njfamirm
Copy link
Member

No description provided.

@njfamirm njfamirm added major This PR causes a major bump in the version number. breaking-change A change that changes the API or breaks backward compatibility for users. labels Nov 27, 2022
@njfamirm njfamirm requested a review from alimd as a code owner November 27, 2022 14:13
@njfamirm njfamirm self-assigned this Nov 27, 2022
@njfamirm njfamirm changed the title refactor: many type! breaking-change: AlwatrDocumentObject type Nov 27, 2022
@alimd alimd changed the title breaking-change: AlwatrDocumentObject type breaking-change: document object and server response types Nov 28, 2022
@njfamirm
Copy link
Member Author

داره سعی میکنه از فتچ بگیره این تایپ رو
خب چون پابلیش نشده نمیتونه

@alimd
Copy link
Member

alimd commented Nov 28, 2022

@njfamirm چیکار داری میکنی؟
دارم ریویو میکنم و میبندمش!
وسط کار شما فرس پوش میکنی باز من پوش میکنم میاد که!

@alimd
Copy link
Member

alimd commented Nov 28, 2022

داره سعی میکنه از فتچ بگیره این تایپ رو خب چون پابلیش نشده نمیتونه

بابا اینو درست کرده بودم که از storage engine بگیره بعد فرس پوش کردی رفت 😢

@njfamirm
Copy link
Member Author

عه ببخشید!
فکر کردم کار نمیکنید

@njfamirm
Copy link
Member Author

خب پس کلا دیگه فورس پوش کنکل

@alimd
Copy link
Member

alimd commented Nov 28, 2022

آره جان ما
اگر مجبور شدی از revert استفاده کن
مگر برنچ خودت بود و هنوز تمام نشده باشه، خلاصه تنهایی

@njfamirm
Copy link
Member Author

چشم

@alimd
Copy link
Member

alimd commented Nov 28, 2022

اینجوری بهتر نیست؟ دیگه به فچ نیازی نیست از طرفی engine واقعا باید این تایپ رو عرضه کنه دیگه
b4bee2c

@njfamirm
Copy link
Member Author

اینجوری بهتر نیست؟ دیگه به فچ نیازی نیست از طرفی engine واقعا باید این تایپ رو عرضه کنه دیگه b4bee2c

چرا

alimd
alimd approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@alimd alimd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

بالاخره تمام شد

@alimd alimd enabled auto-merge November 28, 2022 17:46
@alimd alimd merged commit 1873788 into next Nov 28, 2022
@alimd alimd deleted the feat/type branch November 28, 2022 17:46
@github-actions
Copy link

Pull Request closed and locked due to lack of activity.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2022
@alimd alimd added this to the v1.0.0-beta milestone Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alimd alimd alimd approved these changes

Assignees

@alimd alimd

@njfamirm njfamirm

Labels
breaking-change A change that changes the API or breaks backward compatibility for users. major This PR causes a major bump in the version number.
Projects
None yet
Milestone
v0.x
Development

Successfully merging this pull request may close these issues.
2 participants
@njfamirm @alimd