Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(keep): new PWA! #1052

Merged
merged 37 commits into from
Jun 14, 2023
Merged

feat(keep): new PWA! #1052

merged 37 commits into from
Jun 14, 2023

Conversation

njfamirm
Copy link
Member

No description provided.

@njfamirm njfamirm added the new-feature New features or options. label Apr 17, 2023
@njfamirm njfamirm added this to the v0.x milestone Apr 17, 2023
@njfamirm njfamirm self-assigned this Apr 17, 2023
@njfamirm njfamirm marked this pull request as ready for review May 12, 2023 11:31
@njfamirm njfamirm requested a review from alimd as a code owner May 12, 2023 11:31
wide: true,
headline: 'About Us',
slot: `
Keep is an Iranian holding company in the field of building materials and stone veneer manufacturing. It is engaged in the production and distribution of construction services.<br />

Check failure

Code scanning / ESLint

Enforce a maximum line length

This line has a length of 188. Maximum allowed is 120.
headline: 'About Us',
slot: `
Keep is an Iranian holding company in the field of building materials and stone veneer manufacturing. It is engaged in the production and distribution of construction services.<br />
The factory operates with the aim of distributing construction products in Iranian and international markets.<br />

Check failure

Code scanning / ESLint

Enforce a maximum line length

This line has a length of 121. Maximum allowed is 120.
slot: `
Keep is an Iranian holding company in the field of building materials and stone veneer manufacturing. It is engaged in the production and distribution of construction services.<br />
The factory operates with the aim of distributing construction products in Iranian and international markets.<br />
The products produced by this collection are of high quality and are accompanied by experienced staff committed to customer satisfaction.

Check failure

Code scanning / ESLint

Enforce a maximum line length

This line has a length of 143. Maximum allowed is 120.
uniquely/keep-pwa/src/content/home-page-fa.ts Fixed Show fixed Hide fixed
wide: true,
headline: 'درباره ما',
slot: `
شرکت تولیدی کیپ مصالح ساختمانی و اسکوپ سنگ‌نما هلدینگی ایرانی است که در زمینه تولید و توزیع خدمات ساختمانی فعالیت دارد.<br />

Check failure

Code scanning / ESLint

Enforce a maximum line length

This line has a length of 132. Maximum allowed is 120.
Copy link
Member

@alimd alimd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

متشکرم
زحمت کشیدی
چند تا کامنت نوشتم

اینو برای الان نمیگم ولی اکثر این صفحات و کدها مشترک هستش، کجا بره که همه از اون بگیرن

@njfamirm njfamirm force-pushed the feat/keep branch 2 times, most recently from 40d1110 to cf911bb Compare May 13, 2023 12:02
@njfamirm njfamirm requested a review from alimd May 13, 2023 12:40
@alimd
Copy link
Member

alimd commented May 13, 2023

هر زمان dns ها اکی شد بگو مرج کنم

@njfamirm njfamirm force-pushed the feat/keep branch 2 times, most recently from 1f25fc1 to 094d7b1 Compare May 17, 2023 09:55
@alimd alimd force-pushed the next branch 2 times, most recently from 24ed6ac to a254bb2 Compare May 27, 2023 13:14
@njfamirm njfamirm force-pushed the feat/keep branch 2 times, most recently from 5b79998 to 875211a Compare May 31, 2023 09:18
@alimd alimd merged commit 27dbb2a into next Jun 14, 2023
@alimd alimd deleted the feat/keep branch June 14, 2023 13:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-feature New features or options.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants