Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#117 Create Get String Positions Only Before / After keywords #118

Conversation

robinmatz
Copy link
Collaborator

Closes #117

@Harm10 , please have a look at the acceptance tests in atest/mainframe.robot. I have implemented the keywords in a way that the specified ypos / xpos in Only Before and Only After are themselves not included. I hope that this is the intended behavior.

@robinmatz robinmatz self-assigned this Nov 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e20ba7c) 97.07% compared to head (1b2f425) 96.47%.
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
- Coverage   97.07%   96.47%   -0.60%     
==========================================
  Files          12       12              
  Lines         752      767      +15     
  Branches      170      172       +2     
==========================================
+ Hits          730      740      +10     
- Misses         18       22       +4     
- Partials        4        5       +1     
Flag Coverage Δ
acceptance 83.70% <92.30%> (-1.41%) ⬇️
unit 92.43% <97.43%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Harm10
Copy link
Contributor

Harm10 commented Nov 7, 2023

@robinmatz As I am very busy with other things: what is my dead line? Perhaps I will have time for this coming weekend.

@robinmatz
Copy link
Collaborator Author

robinmatz commented Nov 8, 2023

Hey @Harm10 , no worries, take your time. I'm also trying to do some internal refactoring with this one, which might take a while.

@Harm10
Copy link
Contributor

Harm10 commented Nov 14, 2023

@robinmatz I am sorry I did not find enough time last weekend. I am trying to set-up a brand new venv for Python 3.11.6 but I still have problems. Now with missing tkinter. So you have to bear with me..................

@samuelpcabral
Copy link
Member

Hello @robinmatz should I merge this one or need to wait for @Harm10 review?
Thanks

@Harm10
Copy link
Contributor

Harm10 commented Nov 24, 2023

@robinmatz @samuelpcabral I still have no time to do this properly. I am swamped in work (also in the weekend). I am very sorry.
I ran into new installation problems with my set-up (I solved tkinter and it is not for MF3270) that also need to be resolved first. (Where do you guys find the time :-) ).
So if there is another way to review this please do.

@samuelpcabral samuelpcabral merged commit d8c6e0b into MarketSquare:master Dec 12, 2023
2 of 4 checks passed
@robinmatz robinmatz deleted the 117-create-get-string-positions-only-before-and-after branch December 16, 2023 06:11
@github-actions github-actions bot mentioned this pull request Dec 21, 2023
@github-actions github-actions bot mentioned this pull request Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Get String Positions Only After / Only Before keywords
4 participants