Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More search tests + fix body searching #223

Merged
merged 2 commits into from
Nov 3, 2023
Merged

More search tests + fix body searching #223

merged 2 commits into from
Nov 3, 2023

Conversation

elsand
Copy link
Member

@elsand elsand commented Oct 27, 2023

  • Adds utility functions
    • For manipulating dialog DTOs before submitting (setTitle, setExtendedStatus etc)
    • console.dir for printing objects (not implemented in Goja/K6)
    • expectStatusFor(respo).to.equal(200) as shorthand for expect(response, "response status").to.equal(200), which also displays additional info if an error details reponse
    • Added hasLocalizedText extension to Chai, eg. expect(r.json().items[0], 'first dialog').to.have.property("title").that.hasLocalizedText("some title", "nb_NO"); /* cultureCode optional */
  • Handles serialization of DTOs in request.js, if necessary (no need to remember it at callsite)
  • Add search in "body" in dialogs (will be replaced in Endre dialog-modell mht innholdsfelter (body, title etc) og innfør "summary" #215)

@elsand elsand marked this pull request as ready for review October 27, 2023 11:53
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@elsand elsand merged commit 7eb4ba3 into main Nov 3, 2023
2 checks passed
@elsand elsand deleted the more-search-tests branch November 3, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant