Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web-api): re-enable health checks #1681

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

arealmaas
Copy link
Collaborator

Description

The mapping of health-check endpoints was removed. Re-enabling again now.

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

@arealmaas arealmaas requested a review from a team as a code owner January 14, 2025 08:54
Copy link
Contributor

coderabbitai bot commented Jan 14, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The pull request introduces modifications to the Program.cs file in the ASP.NET application, specifically adding two method calls to the application's configuration pipeline. These additions enable health check endpoint registration and controller attribute routing, which improve the application's monitoring capabilities and request handling mechanism.

Changes

File Change Summary
src/Digdir.Domain.Dialogporten.WebApi/Program.cs Added two method calls in the BuildAndRun method:
- app.MapAspNetHealthChecks() for registering health check endpoints
- .MapControllers() to enable attribute routing for controllers

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6265110 and d60066e.

📒 Files selected for processing (1)
  • src/Digdir.Domain.Dialogporten.WebApi/Program.cs (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@arealmaas arealmaas merged commit 96c2c3e into main Jan 14, 2025
22 of 23 checks passed
@arealmaas arealmaas deleted the fix/include-health-checks branch January 14, 2025 09:00
arealmaas pushed a commit that referenced this pull request Jan 15, 2025
🤖 I have created a release *beep* *boop*
---


##
[1.45.0](v1.44.2...v1.45.0)
(2025-01-15)


### Features

* added id to attachments, ApiActions and GuiActions in DialogCreate
([#1670](#1670))
([470e5a9](470e5a9))
* **apps:** export logs to open telemetry endpoint
([#1617](#1617))
([1a71763](1a71763))
* **janitor:** add otlp logger for janitor
([#1686](#1686))
([2e1656b](2e1656b))


### Bug Fixes

* **app:** Add missing telemetry setup GraphQL and Service
([#1695](#1695))
([601a826](601a826))
* Authentication level claim is 0 in dialog token
([#1654](#1654))
([37e545a](37e545a))
* **graphql:** Add missing activity types
([#1684](#1684))
([a0697ae](a0697ae))
* **graphql:** Set max execution depth to allow inspection query
([#1679](#1679))
([6265110](6265110)),
closes [#1680](#1680)
* **web-api:** re-enable health checks
([#1681](#1681))
([96c2c3e](96c2c3e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants